feat: DH-19382: add server side timing to JsCommandResult (#7145)

Server side PR for DH-19382
Adds server side timing to `JsCommandResult` for query execution time
Tested in deephaven/web-client-ui#2526

Author: jnumainville

go/internal/proto/console/console.pb.go

@@ -121,6 +121,11 @@ message ExecuteCommandRequest {
 message ExecuteCommandResponse {
     string error_message = 1;
     io.deephaven.proto.backplane.grpc.FieldsChangeUpdate changes = 2;
+
+    // Start timestamp for command execution, in nanoseconds since the unix epoch.
+    int64 start_timestamp = 3 [jstype=JS_STRING];
+    // End timestamp for command execution, in nanoseconds since the unix epoch.
+    int64 end_timestamp = 4 [jstype=JS_STRING];
 }
 message BindTableToVariableRequest {
     io.deephaven.proto.backplane.grpc.Ticket console_id = 1;

proto/proto-backplane-grpc/src/main/proto/deephaven_core/proto/console.proto

@@ -6,6 +6,7 @@
 import com.google.common.base.Throwables;
 import com.google.rpc.Code;
 import io.deephaven.base.LockFreeArrayQueue;
+import io.deephaven.base.clock.Clock;
 import io.deephaven.configuration.Configuration;
 import io.deephaven.engine.context.ExecutionContext;
 import io.deephaven.engine.context.QueryScope;
@@ -197,6 +198,7 @@ public void executeCommand(
 
                         // If not set, we'll use defaults, otherwise we will explicitly set the systemicness.
                         final ScriptSession.Changes changes;
+                        long startTimestamp = Clock.system().currentTimeNanos();
                         switch (systemicOption) {
                             case NOT_SET_SYSTEMIC:
                                 changes = scriptSession.evaluateScript(request.getCode());
@@ -213,6 +215,7 @@ public void executeCommand(
                                 throw new UnsupportedOperationException(
                                         "Unrecognized systemic option: " + systemicOption);
                         }
+                        long endTimestamp = Clock.system().currentTimeNanos();
 
                         final ExecuteCommandResponse.Builder diff = ExecuteCommandResponse.newBuilder();
                         final FieldsChangeUpdate.Builder fieldChanges = FieldsChangeUpdate.newBuilder();
@@ -226,7 +229,11 @@ public void executeCommand(
                             diff.setErrorMessage(Throwables.getStackTraceAsString(changes.error));
                             log.error().append("Error running script: ").append(changes.error).endl();
                         }
-                        return diff.setChanges(fieldChanges).build();
+
+                        return diff.setChanges(fieldChanges)
+                                .setStartTimestamp(startTimestamp)
+                                .setEndTimestamp(endTimestamp)
+                                .build();
                     });
         }
     }

py/client/deephaven_core/proto/console_pb2.py

@@ -5,6 +5,7 @@
 
 import com.vertispan.tsdefs.annotations.TsInterface;
 import com.vertispan.tsdefs.annotations.TsName;
+import io.deephaven.web.client.api.DateWrapper;
 import jsinterop.annotations.JsProperty;
 
 /**
@@ -15,10 +16,14 @@
 public class JsCommandResult {
     private final JsVariableChanges changes;
     private final String error;
+    private final String startTimestamp;
+    private final String endTimestamp;
 
-    public JsCommandResult(JsVariableChanges changes, String error) {
+    public JsCommandResult(JsVariableChanges changes, String error, String startTimestamp, String endTimestamp) {
         this.changes = changes;
         this.error = error;
+        this.startTimestamp = startTimestamp;
+        this.endTimestamp = endTimestamp;
     }
 
     /**
@@ -41,6 +46,26 @@ public String getError() {
         return error;
     }
 
+    /**
+     * The timestamp when the command started running.
+     *
+     * @return DateWrapper
+     */
+    @JsProperty
+    public DateWrapper getStartTimestamp() {
+        return DateWrapper.of(Long.parseLong(startTimestamp));
+    }
+
+    /**
+     * The timestamp when the command finished running.
+     *
+     * @return DateWrapper
+     */
+    @JsProperty
+    public DateWrapper getEndTimestamp() {
+        return DateWrapper.of(Long.parseLong(endTimestamp));
+    }
+
     @Override
     public String toString() {
         if (error != null && !error.isEmpty()) {

server/src/main/java/io/deephaven/server/console/ConsoleServiceGrpcImpl.java

@@ -261,10 +261,12 @@ public CancellablePromise<JsCommandResult> runCode(String code) {
         });
         runCodePromise.then(response -> {
             JsVariableChanges changes = JsVariableChanges.from(response.getChanges());
+            final String startTimestamp = response.getStartTimestamp();
+            final String endTimestamp = response.getEndTimestamp();
             if (response.getErrorMessage() == null || response.getErrorMessage().isEmpty()) {
-                promise.succeed(new JsCommandResult(changes, null));
+                promise.succeed(new JsCommandResult(changes, null, startTimestamp, endTimestamp));
             } else {
-                promise.succeed(new JsCommandResult(changes, response.getErrorMessage()));
+                promise.succeed(new JsCommandResult(changes, response.getErrorMessage(), startTimestamp, endTimestamp));
             }
             return null;
         }, err -> {

web/client-api/src/main/java/io/deephaven/web/client/api/console/JsCommandResult.java

@@ -410,6 +410,10 @@ public static native ExecuteCommandResponse.ToObjectReturnType toObject(
 
     public native void setErrorMessage(String value);
 
+    public native String getStartTimestamp();
+
+    public native String getEndTimestamp();
+
     public native ExecuteCommandResponse.ToObjectReturnType0 toObject();
 
     public native ExecuteCommandResponse.ToObjectReturnType0 toObject(boolean includeInstance);