Skip to content

Commit a434d62

Browse files
authored
fix: Increase timeout to almost guarantee 2 PUG cycles to eliminate random test failures (#6560)
random failures on the 2 test cases have been seen in CI/nightly recently.
1 parent b8f301c commit a434d62

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

py/server/tests/test_table_data_service.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -346,8 +346,8 @@ def test_partition_sub_failure(self):
346346
backend.sub_new_partition_fail_test = True
347347
table = data_service.make_table(TableKeyImpl("test"), refreshing=True)
348348
with self.assertRaises(Exception) as cm:
349-
# failure_cb will be called in the background thread after 2 PUG cycles
350-
self.wait_ticking_table_update(table, 600, 2)
349+
# failure_cb will be called in the background thread after 2 PUG cycles, 3 seconds timeout should be enough
350+
self.wait_ticking_table_update(table, 600, 3)
351351
self.assertTrue(table.j_table.isFailed())
352352

353353
def test_partition_size_sub_failure(self):
@@ -358,8 +358,8 @@ def test_partition_size_sub_failure(self):
358358
backend.sub_partition_size_fail_test = True
359359
table = data_service.make_table(TableKeyImpl("test"), refreshing=True)
360360
with self.assertRaises(Exception) as cm:
361-
# failure_cb will be called in the background thread after 2 PUG cycles
362-
self.wait_ticking_table_update(table, 600, 2)
361+
# failure_cb will be called in the background thread after 2 PUG cycles, 3 seconds timeout should be enough
362+
self.wait_ticking_table_update(table, 600, 3)
363363

364364
self.assertTrue(table.j_table.isFailed())
365365

0 commit comments

Comments
 (0)