Barrage: Refactor Read/Write Chunk Factories

Author: nbauernfeind

engine/chunk/src/main/java/io/deephaven/chunk/BooleanChunk.java

@@ -7,6 +7,7 @@
 // @formatter:off
 package io.deephaven.chunk;
 
+import io.deephaven.util.QueryConstants;
 import io.deephaven.util.type.ArrayTypeUtils;
 import io.deephaven.chunk.attributes.Any;
 
@@ -74,6 +75,10 @@ public final boolean get(int index) {
         return data[offset + index];
     }
 
+    public final boolean isNullAt(int index) {
+        return data[offset + index] == QueryConstants.NULL_BOOLEAN;
+    }
+
     @Override
     public BooleanChunk<ATTR> slice(int offset, int capacity) {
         ChunkHelpers.checkSliceArgs(size, offset, capacity);

engine/chunk/src/main/java/io/deephaven/chunk/ByteChunk.java

@@ -7,6 +7,7 @@
 // @formatter:off
 package io.deephaven.chunk;
 
+import io.deephaven.util.QueryConstants;
 import io.deephaven.util.type.ArrayTypeUtils;
 import io.deephaven.chunk.attributes.Any;
 
@@ -78,6 +79,10 @@ public final byte get(int index) {
         return data[offset + index];
     }
 
+    public final boolean isNullAt(int index) {
+        return data[offset + index] == QueryConstants.NULL_BYTE;
+    }
+
     @Override
     public ByteChunk<ATTR> slice(int offset, int capacity) {
         ChunkHelpers.checkSliceArgs(size, offset, capacity);

engine/chunk/src/main/java/io/deephaven/chunk/CharChunk.java

@@ -3,6 +3,7 @@
 //
 package io.deephaven.chunk;
 
+import io.deephaven.util.QueryConstants;
 import io.deephaven.util.type.ArrayTypeUtils;
 import io.deephaven.chunk.attributes.Any;
 
@@ -73,6 +74,10 @@ public final char get(int index) {
         return data[offset + index];
     }
 
+    public final boolean isNullAt(int index) {
+        return data[offset + index] == QueryConstants.NULL_CHAR;
+    }
+
     @Override
     public CharChunk<ATTR> slice(int offset, int capacity) {
         ChunkHelpers.checkSliceArgs(size, offset, capacity);

engine/chunk/src/main/java/io/deephaven/chunk/Chunk.java

@@ -109,6 +109,12 @@ default void copyToBuffer(int srcOffset, @NotNull Buffer destBuffer, int destOff
      */
     int size();
 
+    /**
+     * @return whether The value offset is null
+     * @param index The index to check
+     */
+    boolean isNullAt(int index);
+
     /**
      * @return The underlying chunk type
      */

engine/chunk/src/main/java/io/deephaven/chunk/DoubleChunk.java

@@ -7,6 +7,7 @@
 // @formatter:off
 package io.deephaven.chunk;
 
+import io.deephaven.util.QueryConstants;
 import io.deephaven.util.type.ArrayTypeUtils;
 import io.deephaven.chunk.attributes.Any;
 
@@ -77,6 +78,10 @@ public final double get(int index) {
         return data[offset + index];
     }
 
+    public final boolean isNullAt(int index) {
+        return data[offset + index] == QueryConstants.NULL_DOUBLE;
+    }
+
     @Override
     public DoubleChunk<ATTR> slice(int offset, int capacity) {
         ChunkHelpers.checkSliceArgs(size, offset, capacity);

engine/chunk/src/main/java/io/deephaven/chunk/FloatChunk.java

@@ -7,6 +7,7 @@
 // @formatter:off
 package io.deephaven.chunk;
 
+import io.deephaven.util.QueryConstants;
 import io.deephaven.util.type.ArrayTypeUtils;
 import io.deephaven.chunk.attributes.Any;
 
@@ -77,6 +78,10 @@ public final float get(int index) {
         return data[offset + index];
     }
 
+    public final boolean isNullAt(int index) {
+        return data[offset + index] == QueryConstants.NULL_FLOAT;
+    }
+
     @Override
     public FloatChunk<ATTR> slice(int offset, int capacity) {
         ChunkHelpers.checkSliceArgs(size, offset, capacity);

engine/chunk/src/main/java/io/deephaven/chunk/IntChunk.java

@@ -7,6 +7,7 @@
 // @formatter:off
 package io.deephaven.chunk;
 
+import io.deephaven.util.QueryConstants;
 import io.deephaven.util.type.ArrayTypeUtils;
 import io.deephaven.chunk.attributes.Any;
 
@@ -77,6 +78,10 @@ public final int get(int index) {
         return data[offset + index];
     }
 
+    public final boolean isNullAt(int index) {
+        return data[offset + index] == QueryConstants.NULL_INT;
+    }
+
     @Override
     public IntChunk<ATTR> slice(int offset, int capacity) {
         ChunkHelpers.checkSliceArgs(size, offset, capacity);

engine/chunk/src/main/java/io/deephaven/chunk/LongChunk.java

@@ -7,6 +7,7 @@
 // @formatter:off
 package io.deephaven.chunk;
 
+import io.deephaven.util.QueryConstants;
 import io.deephaven.util.type.ArrayTypeUtils;
 import io.deephaven.chunk.attributes.Any;
 
@@ -77,6 +78,10 @@ public final long get(int index) {
         return data[offset + index];
     }
 
+    public final boolean isNullAt(int index) {
+        return data[offset + index] == QueryConstants.NULL_LONG;
+    }
+
     @Override
     public LongChunk<ATTR> slice(int offset, int capacity) {
         ChunkHelpers.checkSliceArgs(size, offset, capacity);

engine/chunk/src/main/java/io/deephaven/chunk/ObjectChunk.java

@@ -7,6 +7,7 @@
 // @formatter:off
 package io.deephaven.chunk;
 
+import io.deephaven.util.QueryConstants;
 import io.deephaven.util.type.ArrayTypeUtils;
 import io.deephaven.chunk.attributes.Any;
 
@@ -77,6 +78,10 @@ public final T get(int index) {
         return data[offset + index];
     }
 
+    public final boolean isNullAt(int index) {
+        return data[offset + index] == null;
+    }
+
     @Override
     public ObjectChunk<T, ATTR> slice(int offset, int capacity) {
         ChunkHelpers.checkSliceArgs(size, offset, capacity);

engine/chunk/src/main/java/io/deephaven/chunk/ShortChunk.java

@@ -7,6 +7,7 @@
 // @formatter:off
 package io.deephaven.chunk;
 
+import io.deephaven.util.QueryConstants;
 import io.deephaven.util.type.ArrayTypeUtils;
 import io.deephaven.chunk.attributes.Any;
 
@@ -77,6 +78,10 @@ public final short get(int index) {
         return data[offset + index];
     }
 
+    public final boolean isNullAt(int index) {
+        return data[offset + index] == QueryConstants.NULL_SHORT;
+    }
+
     @Override
     public ShortChunk<ATTR> slice(int offset, int capacity) {
         ChunkHelpers.checkSliceArgs(size, offset, capacity);