ci: Remove python 3.8 from tests and add python 3.13 (#1244) (#1246)

- Cherry-picking #1244 to the ui-v0.31 branch
- Had a release action fail because this wasn't picked back:
https://github.com/deephaven/deephaven-plugins/actions/runs/18534550865
- Python 3.8 is past EOL: https://devguide.python.org/versions/
- jpy no longer publishes wheels for Python 3.8:
jpy-consortium/jpy#201
- Logged a ticket for deephaven-core to update requirements:
https://deephaven.atlassian.net/browse/DH-20615
- For the deephaven-plugins tests, just remove 3.8 and add 3.13 (since
it should be supported as well)

Author: mofojed

.github/actions/get-changes/action.yml

@@ -13,17 +13,8 @@ runs:
       uses: dorny/paths-filter@v3
       id: filter
       with:
+        # On this release/ui-v0.31 branch, just disable all the other plugins from being tested since it will just be deephaven.ui updates
         filters: |
-          plotly-express:
-            - plugins/plotly-express/**
-            - .github/workflows/test-*.yml
-            - sphinx_ext/*
-          matplotlib:
-            - plugins/matplotlib/**
-            - .github/workflows/test-*.yml
-          json:
-            - plugins/json/**
-            - .github/workflows/test-*.yml
           ui:
             - plugins/ui/**
             - .github/workflows/test-*.yml
@@ -34,9 +25,3 @@ runs:
           packaging:
             - plugins/packaging/**
             - .github/workflows/test-*.yml
-          ag-grid:
-            - plugins/ag-grid/**
-            - .github/workflows/test-*.yml
-          simple-pivot:
-            - plugins/simple-pivot/**
-            - .github/workflows/test-*.yml

.github/workflows/pre-commit.yml

@@ -19,6 +19,6 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-python@v5
         with:
-          python-version: '3.8'
+          python-version: '3.9'
           cache: 'pip'
       - uses: pre-commit/[email protected]

.github/workflows/test-python-package.yml

@@ -13,7 +13,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python: ['3.8', '3.9', '3.10', '3.11', '3.12']
+        python: ['3.9', '3.10', '3.11', '3.12', '3.13']
     steps:
       - name: Checkout
         uses: actions/checkout@v4

README.md

@@ -78,22 +78,13 @@ If you want to run tests locally (which may be easier for debugging or creating
 
 The [venv setup](#pre-commit-hookspython-formatting) steps will also set up `tox` to run tests for the python plugins that support it.
 Note that `tox` sets up an isolated environment for running tests.  
-Be default, `tox` will run against Python 3.8, which will need to be installed on your system before running tests.
+Be default, `tox` will run against Python 3.9, which will need to be installed on your system before running tests.
 You can run tests with the following command from the `plugins/<plugin>` directory:
 
 ```shell
 tox -e py
 ```
 
-> [!IMPORTANT]
-> Linux, and possibly other setups such as MacOS depending on method, may require additional packages to be installed to run Python 3.8.
->
-> ```shell
-> sudo apt install python3.8 python3.8-distutils libpython3.8
-> # or just full install although it will include more packages than necessary
-> sudo apt install python3.8-full
-> ```
-
 You can also run tests against a specific version of python by appending the version to `py`  
 This assumes that the version of Python you're targeting is installed on your system.  
 For example, to run tests against Python 3.12, run:

plugins/ag-grid/tox.ini

@@ -6,10 +6,7 @@ deps =
     deephaven-server
 commands =
     python -m unittest {posargs}
-basepython = python3.8
-
-[testenv:py3.8]
-basepython = python3.8
+basepython = python3.9
 
 [testenv:py3.9]
 basepython = python3.9
@@ -21,4 +18,7 @@ basepython = python3.10
 basepython = python3.11
 
 [testenv:py3.12]
-basepython = python3.12
+basepython = python3.12
+
+[testenv:py3.13]
+basepython = python3.13

plugins/matplotlib/tox.ini

@@ -0,0 +1,22 @@
+[tox]
+isolated_build = True
+
+[testenv]
+deps =
+    deephaven-server
+basepython = python3.9
+
+[testenv:py3.9]
+basepython = python3.9
+
+[testenv:py3.10]
+basepython = python3.10
+
+[testenv:py3.11]
+basepython = python3.11
+
+[testenv:py3.12]
+basepython = python3.12
+
+[testenv:py3.13]
+basepython = python3.13

plugins/packaging/tox.ini

@@ -0,0 +1,22 @@
+[tox]
+isolated_build = True
+
+[testenv]
+deps =
+    deephaven-server
+basepython = python3.9
+
+[testenv:py3.9]
+basepython = python3.9
+
+[testenv:py3.10]
+basepython = python3.10
+
+[testenv:py3.11]
+basepython = python3.11
+
+[testenv:py3.12]
+basepython = python3.12
+
+[testenv:py3.13]
+basepython = python3.13

plugins/plotly-express/tox.ini

@@ -6,10 +6,7 @@ deps =
     deephaven-server
 commands =
     python -m unittest discover
-basepython = python3.8
-
-[testenv:py3.8]
-basepython = python3.8
+basepython = python3.9
 
 [testenv:py3.9]
 basepython = python3.9
@@ -23,4 +20,5 @@ basepython = python3.11
 [testenv:py3.12]
 basepython = python3.12
 
-
+[testenv:py3.13]
+basepython = python3.13

plugins/simple-pivot/tox.ini

@@ -6,10 +6,7 @@ deps =
     deephaven-server
 commands =
     python -m unittest {posargs}
-basepython = python3.8
-
-[testenv:py3.8]
-basepython = python3.8
+basepython = python3.9
 
 [testenv:py3.9]
 basepython = python3.9
@@ -21,4 +18,7 @@ basepython = python3.10
 basepython = python3.11
 
 [testenv:py3.12]
-basepython = python3.12
+basepython = python3.12
+
+[testenv:py3.13]
+basepython = python3.13

plugins/ui/test/deephaven/ui/test_ui_table.py

@@ -19,9 +19,7 @@ def expect_render(self, ui_table, expected_props: dict[str, Any]):
         context = RenderContext(on_change, on_queue)
         result = ui_table.render(context)
 
-        # Can replace 2nd param with result | expected_props after dropping Python 3.8
-        # https://stackoverflow.com/questions/20050913/python-unittests-assertdictcontainssubset-recommended-alternative
-        self.assertDictEqual(result, {**result, **expected_props})
+        self.assertDictEqual(result, result | expected_props)
 
     def test_empty_ui_table(self):
         import deephaven.ui as ui