Skip to content

Commit d72a5f7

Browse files
authored
ci: Disable flakey histogram test (#1251)
- This test is bugging me. Filed DH-20738 to figure out why it's causing issues, but disabling for now to unblock other PRs
1 parent 7d091d3 commit d72a5f7

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

tests/express.spec.ts

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,12 @@ test('Plotly loads', async ({ page }) => {
1313
await expect(page.locator('.iris-chart-panel')).toHaveScreenshot();
1414
});
1515

16-
test('Histogram loads', async ({ page }) => {
17-
await gotoPage(page, '');
18-
await openPanel(page, 'express_hist_by', '.js-plotly-plot');
19-
await expect(page.locator('.iris-chart-panel')).toHaveScreenshot();
20-
});
16+
// TODO: DH-20738 Enable histogram test, it seems to be flakey
17+
// test('Histogram loads', async ({ page }) => {
18+
// await gotoPage(page, '');
19+
// await openPanel(page, 'express_hist_by', '.js-plotly-plot');
20+
// await expect(page.locator('.iris-chart-panel')).toHaveScreenshot();
21+
// });
2122

2223
test('Indicator loads', async ({ page }) => {
2324
await gotoPage(page, '');
@@ -38,9 +39,9 @@ test('Ticking loads', async ({ page }) => {
3839
});
3940

4041
test('Partitioned loads', async ({ page }) => {
41-
await gotoPage(page, '');
42-
await openPanel(page, 'partitioned_fig', '.js-plotly-plot');
43-
await expect(page.locator('.iris-chart-panel')).toHaveScreenshot();
42+
await gotoPage(page, '');
43+
await openPanel(page, 'partitioned_fig', '.js-plotly-plot');
44+
await expect(page.locator('.iris-chart-panel')).toHaveScreenshot();
4445
});
4546

4647
test('Figure with title loads', async ({ page }) => {
@@ -101,4 +102,4 @@ test('Candlestick chart loads', async ({ page }) => {
101102
await gotoPage(page, '');
102103
await openPanel(page, 'candlestick_fig', '.js-plotly-plot');
103104
await expect(page.locator('.iris-chart-panel')).toHaveScreenshot();
104-
});
105+
});

0 commit comments

Comments
 (0)