Fixing npm ci (DH-18428-4)

Author: bmingles

.github/workflows/e2e.yml

@@ -24,17 +24,20 @@ jobs:
         with:
           node-version-file: '.nvmrc'
           cache: 'npm'
-      - name: Configure npm to use Git Bash on Windows
-        if: runner.os == 'Windows'
-        run: npm config set shell "C:\\Program Files\\Git\\bin\\bash.exe"
-        shell: cmd # Run this command in cmd.exe to set npm config
-      - run: npm ci
-      - name: Run end-to-end tests (Linux)
-        if: runner.os == 'Linux'
-        run: xvfb-run npm run test:e2e
-      - name: Run end-to-end tests (Windows)
-        if: runner.os == 'Windows'
-        run: npm run test:e2e
+      - name: Install Dependencies
+        run: |
+          if [ "${{ runner.os }}" = "Windows" ]; then
+            "C:/Program Files/Git/bin/bash.exe" -c "npm ci"
+          else
+            npm ci
+          fi
+      - name: Run end-to-end tests
+        run: |
+          if [ "${{ runner.os }}" = "Windows" ]; then
+            "C:/Program Files/Git/bin/bash.exe" -c "npm run test:e2e"
+          else
+            npm run test:e2e
+          fi
       - name: Upload Screenshots as Artifact
         if: ${{ always() }}
         uses: actions/upload-artifact@v4