Skip to content

Commit f8e4f22

Browse files
authored
build: Remove lodash.set and a high vulnerability identified (#2589)
- Dependabot reported vulnerability CVE-2020-8203 in lodash.set - GHSA-p6mc-m468-83gw - Should no longer be importing lodash.set directly, encouraged to just use lodash package directly and use the imports necessary - lodash/lodash#6061 - Just update to lodash instead, rebuild
1 parent 39e389c commit f8e4f22

File tree

5 files changed

+16
-29
lines changed

5 files changed

+16
-29
lines changed

package-lock.json

Lines changed: 12 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,12 +83,11 @@
8383
"@types/eslint": "^8.4.10",
8484
"@types/jest": "^29.2.5",
8585
"@types/jquery": "^3.5.14",
86-
"@types/lodash": "^4.14.182",
86+
"@types/lodash": "^4.17.21",
8787
"@types/lodash.clamp": "^4.0.6",
8888
"@types/lodash.debounce": "^4.0.6",
8989
"@types/lodash.flatten": "^4.4.0",
9090
"@types/lodash.merge": "^4.6.9",
91-
"@types/lodash.set": "^4.3.7",
9291
"@types/lodash.throttle": "^4.1.1",
9392
"@types/memoizee": "^0.4.5",
9493
"@types/node": "^24.8.0",

packages/chart/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,7 @@
3636
"@deephaven/utils": "file:../utils",
3737
"buffer": "^6.0.3",
3838
"fast-deep-equal": "^3.1.3",
39-
"lodash.debounce": "^4.0.8",
40-
"lodash.set": "^4.3.2",
39+
"lodash": "^4.17.21",
4140
"memoize-one": "^5.1.1",
4241
"memoizee": "^0.4.15",
4342
"plotly.js": "3.1.0",

packages/chart/src/ChartUtils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
TableUtils,
77
} from '@deephaven/jsapi-utils';
88
import type { dh as DhType } from '@deephaven/jsapi-types';
9-
import set from 'lodash.set';
9+
import { set } from 'lodash';
1010
import type {
1111
Layout,
1212
PlotData,

packages/chart/src/FigureChartModel.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
/* eslint class-methods-use-this: "off" */
22
import memoize from 'memoizee';
3-
import debounce from 'lodash.debounce';
4-
import set from 'lodash.set';
3+
import { debounce, set } from 'lodash';
54
import type { dh as DhType } from '@deephaven/jsapi-types';
65
import Log from '@deephaven/log';
76
import { type Range } from '@deephaven/utils';

0 commit comments

Comments
 (0)