fix: Cherry-pick DH-20319: Stuck to bottom of table not sticking (#2547) #2578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I believe the functionality stopped working after deephaven@9f87985, where an added `setState` call at the end of `componentDidUpdate` would overwrite any scroll position state state changes made in `checkStickyScroll()` - Now the relevant scroll position state changes are made in the same `setState` call at the end of `componentDidUpdate` - Added an e2e test to test the stuck to bottom scrolling functionality # Conflicts: # tests/table-scroll.spec.ts
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v0.85 #2578 +/- ##
=================================================
+ Coverage 48.43% 48.45% +0.02%
=================================================
Files 712 712
Lines 39734 39736 +2
Branches 9921 10110 +189
=================================================
+ Hits 19244 19253 +9
+ Misses 20477 20426 -51
- Partials 13 57 +44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ericlln
requested review from
a team and
bmingles
and removed request for
a team
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #2547 into
v0.85