Skip to content

Conversation

@mofojed
Copy link
Member

@mofojed mofojed commented Nov 27, 2025

  • I got bit with package-lock updating when switching from release/v0.85 to main branch
  • Just restrict it using engines so we don't get bit

- I got bit with package-lock updating when switching from release/v0.85 to main branch
- Just restrict it using engines so we don't get bit
@mofojed mofojed requested a review from dsmmcken November 27, 2025 15:02
@mofojed mofojed self-assigned this Nov 27, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.48%. Comparing base (1bba969) to head (4238efb).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2584    +/-   ##
========================================
  Coverage   45.48%   45.48%            
========================================
  Files         771      771            
  Lines       43591    43591            
  Branches    11027    11211   +184     
========================================
  Hits        19827    19827            
+ Misses      23748    23718    -30     
- Partials       16       46    +30     
Flag Coverage Δ
unit 45.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mofojed mofojed merged commit c1b5859 into deephaven:main Nov 27, 2025
11 checks passed
@mofojed mofojed deleted the update-node-engine-v24 branch November 27, 2025 15:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants