Skip to content

Conversation

@vbabich
Copy link
Collaborator

@vbabich vbabich commented Dec 24, 2025

Update GridUtils.getColumnSeparatorIndex to take column group depth into account.

BREAKING CHANGE: getColumnSeparatorIndex now requires a model argument.

@vbabich vbabich self-assigned this Dec 24, 2025
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.24%. Comparing base (fa61b3b) to head (a4bd04e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/grid/src/GridUtils.ts 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2597      +/-   ##
==========================================
- Coverage   45.48%   45.24%   -0.25%     
==========================================
  Files         771      771              
  Lines       43591    43604      +13     
  Branches    11027    11035       +8     
==========================================
- Hits        19827    19727     -100     
- Misses      23748    23861     +113     
  Partials       16       16              
Flag Coverage Δ
unit 45.24% <86.66%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vbabich vbabich marked this pull request as ready for review January 2, 2026 18:06
@vbabich vbabich requested review from a team and bmingles and removed request for a team January 2, 2026 18:06
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbabich vbabich merged commit f2d6ced into deephaven:main Jan 2, 2026
10 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants