Skip to content

Comments

fix: Typing for onLayoutConfigChange#2622

Merged
mofojed merged 1 commit intodeephaven:mainfrom
mofojed:fix-dashboard-layout-config-type
Feb 11, 2026
Merged

fix: Typing for onLayoutConfigChange#2622
mofojed merged 1 commit intodeephaven:mainfrom
mofojed:fix-dashboard-layout-config-type

Conversation

@mofojed
Copy link
Member

@mofojed mofojed commented Feb 11, 2026

  • Was typed as a () => void, rather than the type that was actually being passed back

- Was typed as a () => void, rather than the type that was actually being passed back
@mofojed mofojed requested a review from a team February 11, 2026 22:33
@mofojed mofojed self-assigned this Feb 11, 2026
@mofojed mofojed requested review from vbabich and removed request for a team February 11, 2026 22:33
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.52%. Comparing base (295322f) to head (ab82d8d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2622      +/-   ##
==========================================
- Coverage   49.53%   49.52%   -0.01%     
==========================================
  Files         774      774              
  Lines       43767    43767              
  Branches    11072    11072              
==========================================
- Hits        21678    21674       -4     
- Misses      22071    22075       +4     
  Partials       18       18              
Flag Coverage Δ
unit 49.52% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mofojed mofojed merged commit 83ae200 into deephaven:main Feb 11, 2026
11 checks passed
@mofojed mofojed deleted the fix-dashboard-layout-config-type branch February 11, 2026 23:26
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants