Merge branch 'main' of github.com:deephyper/deephyper-spack-packages into main

Author: Deathn0t

LICENSE

@@ -0,0 +1,28 @@
+BSD 3-Clause License
+
+Copyright (c) 2023, DeepHyper Team
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are met:
+
+1. Redistributions of source code must retain the above copyright notice, this
+   list of conditions and the following disclaimer.
+
+2. Redistributions in binary form must reproduce the above copyright notice,
+   this list of conditions and the following disclaimer in the documentation
+   and/or other materials provided with the distribution.
+
+3. Neither the name of the copyright holder nor the names of its
+   contributors may be used to endorse or promote products derived from
+   this software without specific prior written permission.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

README.md

@@ -1,12 +1,16 @@
 # DeepHyper Spack Packages
 
+## Overview
+
 This repository contains a collection of [Spack](https://spack.io) packages to manage the building of DeepHyper from source. Start by installing Spack on your system:
 
 ```bash
 git clone -c feature.manyFiles=true https://github.com/spack/spack.git
 . ./spack/share/spack/setup-env.sh 
 ```
 
+Spack is quite recent and evolving quickly. Many packages are regularly updated. Therefore it can sometimes be useful to checkout the `develop` branch of Spack (`git checkout develop`) in case of issue to see if a fix has already been provided but not yet released.
+
 Now should have access to the `spack` command. If you need spack to be loaded for any new session of your shell then you can add `. $PATH_TO_SPACK/spack/share/spack/setup-env.sh` to your `~/.bashrc` (or any other shell configuration). Once Spack is installed and loaded. Download the DeepHyper Spack packages and add them to your Spack installer:
 
 
@@ -57,3 +61,29 @@ The `info` command can help retrieve more information about the possible variant
 ```bash
 spack info py-deephyper
 ```
+
+## Accessing Shared Site Packages
+
+Sometimes the HPC facility can provide already compiled/installed packages. Spack can reuse these packages by defining a new `upstream` configuration. After cloning the Spack repository and activating the Spack environment (the command `spack` should now be available in your shell) add a new upstream configuration in the YAML file `$SPACK_ROOT/etc/spack/upstream.yaml` (`$SPACK_ROOT` should be available in your environment after activation of Spack).
+
+At the Argonne Leadership Computing Facility (ALCF), Spack packages are provided at the `/soft/spack/root/opt/spack` location. Therefore we can edit the `upstream.yaml` file such as:
+
+
+```yaml
+upstreams: 
+    alcf-spack: 
+        install_tree: /soft/spack/root/opt/spack
+```
+
+More information about [Chaining Spack Installations](https://spack.readthedocs.io/en/latest/chain.html#using-multiple-upstream-spack-instances).
+
+## Spack and Conda
+
+```
+spack add miniconda3
+```
+
+for mac with arm64 use the `conda-forge` channel!
+```
+conda install -c conda-forge ...
+```

packages/py-deephyper/package.py

@@ -56,6 +56,7 @@ class PyDeephyper(PythonPackage):
         depends_on("[email protected]:", type=("build", "run"))
 
     with when("+nas"):
+        #! Building tensorflow currently fails on "darwin-ventura-m1"
         depends_on("py-tensorflow@2:", type=("build", "run"))
         depends_on("py-networkx", type=("build", "run"))
         depends_on("py-pydot", type=("build", "run"))