Skip to content

Commit 918bcec

Browse files
committed
Changed to use custom s5cmd build w go 1.24.2 to address CVEs and also added new integration tests to workflow
1 parent 0971984 commit 918bcec

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

.github/workflows/integration.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,15 @@ jobs:
184184
- test: TestStatefulModel
185185
instance: g6
186186
failure-prefix: lmi
187+
- test: TestSageMakerCompatibility
188+
instance: cpu
189+
failure-prefix: cpu
190+
- test: TestCustomFormatters
191+
instance: cpu
192+
failure-prefix: cpu
193+
- test: TestXgbSkl
194+
instance: cpu
195+
failure-prefix: cpu
187196
outputs:
188197
failure_cpu: ${{ steps.test-failure.outputs.failure_cpu }}
189198
failure_gpu: ${{ steps.test-failure.outputs.failure_gpu }}

serving/docker/scripts/install_s5cmd.sh

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,18 @@ set -ex
44

55
ARCH=$1
66

7+
# Download custom s5cmd binary built with Go 1.24.2
78
if [[ $ARCH == "aarch64" ]]; then
8-
curl https://github.com/peak/s5cmd/releases/download/v2.3.0/s5cmd_2.3.0_Linux-arm64.tar.gz -L -o s5cmd.tar.gz
9+
curl -f https://publish.djl.ai/s5cmd/go1.24.2/s5cmd-linux-arm64 -L -o s5cmd
910
else
10-
curl https://github.com/peak/s5cmd/releases/download/v2.3.0/s5cmd_2.3.0_Linux-64bit.tar.gz -L -o s5cmd.tar.gz
11+
curl -f https://publish.djl.ai/s5cmd/go1.24.2/s5cmd-linux-amd64 -L -o s5cmd
1112
fi
1213

1314
INSTALL_DIR="/opt/djl/bin"
1415

1516
mkdir -p "${INSTALL_DIR}"
16-
tar -xvf s5cmd.tar.gz -C "${INSTALL_DIR}"
17-
rm -rf s5cmd.tar.gz
17+
mv s5cmd "${INSTALL_DIR}/"
18+
chmod +x "${INSTALL_DIR}/s5cmd"
1819

1920
export PATH="${INSTALL_DIR}:${PATH}"
2021
echo "export PATH=${INSTALL_DIR}:\$PATH" >>~/.bashrc

0 commit comments

Comments
 (0)