Skip to content

Commit 1da2893

Browse files
committed
replace ENABLE_DEEPKS & ENABLE_MLKEDF with ENABLE_ML4DFT
1 parent 6654849 commit 1da2893

File tree

15 files changed

+26
-24
lines changed

15 files changed

+26
-24
lines changed

.github/workflows/build_test_cmake.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ jobs:
1717
name: "Build with Intel toolchain"
1818

1919
- tag: gnu
20-
build_args: "-DENABLE_LIBXC=1 -DENABLE_DEEPKS=1 -DENABLE_MLKEDF=1 -DENABLE_LIBRI=1"
20+
build_args: "-DENABLE_LIBXC=1 -DDENABLE_ML4DFT=1 -DENABLE_LIBRI=1"
2121
name: "Build extra components with GNU toolchain"
2222
- tag: intel
23-
build_args: "-DENABLE_LIBXC=1 -DENABLE_DEEPKS=1 -DENABLE_MLKEDF=1 -DENABLE_LIBRI=1"
23+
build_args: "-DENABLE_LIBXC=1 -DENABLE_ML4DFT=1 -DENABLE_LIBRI=1"
2424
name: "Build extra components with Intel toolchain"
2525

2626
- tag: cuda

.github/workflows/coverage.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
apt update && apt install -y lcov gpg curl jq ca-certificates
1919
- name: Building
2020
run: |
21-
cmake -B build -DENABLE_COVERAGE=ON -DBUILD_TESTING=ON -DENABLE_DEEPKS=ON -DENABLE_LIBXC=ON -DENABLE_LIBRI=ON -DENABLE_GOOGLEBENCH=ON -DENABLE_RAPIDJSON=ON
21+
cmake -B build -DENABLE_COVERAGE=ON -DBUILD_TESTING=ON -DENABLE_ML4DFT=ON -DENABLE_LIBXC=ON -DENABLE_LIBRI=ON -DENABLE_GOOGLEBENCH=ON -DENABLE_RAPIDJSON=ON
2222
cmake --build build -j`nproc`
2323
cmake --install build
2424
- name: Testing

.github/workflows/dynamic.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
uses: actions/checkout@v4
1717
- name: Building
1818
run: |
19-
cmake -B build -DENABLE_ASAN=1 -DENABLE_DEEPKS=1 -DENABLE_LIBXC=1
19+
cmake -B build -DENABLE_ASAN=1 -DENABLE_ML4DFT=1 -DENABLE_LIBXC=1
2020
cmake --build build -j8
2121
cmake --install build
2222
- name: Testing

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
3232
- name: Configure
3333
run: |
34-
cmake -B build -DBUILD_TESTING=ON -DENABLE_DEEPKS=ON -DENABLE_MLKEDF=ON -DENABLE_LIBXC=ON -DENABLE_LIBRI=ON -DENABLE_GOOGLEBENCH=ON -DENABLE_RAPIDJSON=ON -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -DENABLE_FLOAT_FFTW=ON
34+
cmake -B build -DBUILD_TESTING=ON -DENABLE_ML4DFT=ON -DENABLE_LIBXC=ON -DENABLE_LIBRI=ON -DENABLE_GOOGLEBENCH=ON -DENABLE_RAPIDJSON=ON -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -DENABLE_FLOAT_FFTW=ON
3535
3636
# Temporarily removed because no one maintains this now.
3737
# And it will break the CI test workflow.

CMakeLists.txt

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,11 @@ option(USE_DSP "Enable DSP" OFF)
2121
option(USE_ABACUS_LIBM "Build libmath from source to speed up" OFF)
2222
option(ENABLE_LIBXC "Enable using the LibXC package" OFF)
2323
option(ENABLE_FLOAT_FFTW "Enable using single-precision FFTW library." OFF)
24-
option(ENABLE_DEEPKS "Enable the DeePKS algorithm" OFF)
25-
option(ENABLE_MLKEDF "Enable the Machine-Learning-based KEDF for OFDFT" OFF)
24+
25+
# option(ENABLE_DEEPKS "Enable the DeePKS algorithm" OFF)
26+
# option(ENABLE_MLKEDF "Enable the Machine-Learning-based KEDF for OFDFT" OFF)
27+
28+
option(ENABLE_ML4DFT "Enable the Machine-Learning for OFDFT" OFF)
2629

2730
option(ENABLE_LCAO "Enable LCAO algorithm" ON)
2831
option(USE_ELPA "Enable ELPA for LCAO" ON)
@@ -115,7 +118,7 @@ endif()
115118
# Serial version of ABACUS will not use ELPA
116119
if(NOT ENABLE_MPI)
117120
set(USE_ELPA OFF)
118-
set(ENABLE_DEEPKS OFF)
121+
set(ENABLE_ML4DFT OFF)
119122
endif()
120123

121124
# Different exe files of ABACUS
@@ -253,7 +256,7 @@ if(ENABLE_LCAO)
253256
add_compile_definitions(__NEW_GINT)
254257
endif()
255258
else()
256-
set(ENABLE_DEEPKS OFF)
259+
set(ENABLE_ML4DFT OFF)
257260
set(ENABLE_LIBRI OFF)
258261
endif()
259262

@@ -480,7 +483,7 @@ if(ENABLE_FLOAT_FFTW)
480483
add_definitions(-D__ENABLE_FLOAT_FFTW)
481484
endif()
482485

483-
if(ENABLE_DEEPKS)
486+
if(ENABLE_ML4DFT)
484487
target_link_libraries(${ABACUS_BIN_NAME} deepks)
485488

486489
find_path(libnpy_SOURCE_DIR npy.hpp HINTS ${libnpy_INCLUDE_DIR})
@@ -499,7 +502,7 @@ if(ENABLE_DEEPKS)
499502
add_compile_definitions(__DEEPKS)
500503
endif()
501504

502-
if(ENABLE_MLKEDF)
505+
if(ENABLE_ML4DFT)
503506
target_link_libraries(${ABACUS_BIN_NAME} hamilt_mlkedf)
504507

505508
find_path(libnpy_SOURCE_DIR npy.hpp HINTS ${libnpy_INCLUDE_DIR})
@@ -521,7 +524,7 @@ endif()
521524
# Torch uses outdated components to detect CUDA arch, causing failure on
522525
# latest CUDA kits. Set CMake variable TORCH_CUDA_ARCH_LIST in the form of
523526
# "major.minor" if required.
524-
if(ENABLE_DEEPKS OR ENABLE_MLKEDF OR DEFINED Torch_DIR)
527+
if(ENABLE_ML4DFT OR DEFINED Torch_DIR)
525528
find_package(Torch REQUIRED)
526529
if(NOT Torch_VERSION VERSION_LESS "2.1.0")
527530
set_if_higher(CMAKE_CXX_STANDARD 17)

Dockerfile.gnu

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ ADD https://api.github.com/repos/deepmodeling/abacus-develop/git/refs/heads/deve
3434

3535
RUN git clone https://github.com/deepmodeling/abacus-develop.git --depth 1 && \
3636
cd abacus-develop && \
37-
cmake -B build -DENABLE_DEEPKS=ON -DENABLE_LIBXC=ON -DENABLE_LIBRI=ON -DENABLE_RAPIDJSON=ON && \
37+
cmake -B build -DENABLE_ML4DFT=ON -DENABLE_LIBXC=ON -DENABLE_LIBRI=ON -DENABLE_RAPIDJSON=ON && \
3838
cmake --build build -j`nproc` && \
3939
cmake --install build && \
4040
rm -rf build

Dockerfile.intel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ ADD https://api.github.com/repos/deepmodeling/abacus-develop/git/refs/heads/deve
5858
RUN source /opt/intel/oneapi/setvars.sh && \
5959
git clone https://github.com/deepmodeling/abacus-develop.git --depth 1 && \
6060
cd abacus-develop && \
61-
cmake -B build -DENABLE_DEEPKS=ON -DENABLE_LIBXC=ON -DENABLE_LIBRI=ON -DENABLE_RAPIDJSON=ON && \
61+
cmake -B build -DENABLE_ML4DFT=ON -DENABLE_LIBXC=ON -DENABLE_LIBRI=ON -DENABLE_RAPIDJSON=ON && \
6262
cmake --build build -j`nproc` && \
6363
cmake --install build && \
6464
rm -rf build && \

conda/meta.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ build:
2626
skip: true # [not linux]
2727
script: |
2828
export CMAKE_PREFIX_PATH=`python -c "import torch;print(torch.__path__[0])"`/share/cmake:$CMAKE_PREFIX_PATH
29-
cmake -B conda_build ${CMAKE_ARGS} -DCMAKE_BUILD_TYPE=Release -DENABLE_DEEPKS=1 -DENABLE_LIBXC=1
29+
cmake -B conda_build ${CMAKE_ARGS} -DCMAKE_BUILD_TYPE=Release -DENABLE_ML4DFT=1 -DENABLE_LIBXC=1
3030
cmake --build conda_build -j`nproc`
3131
cmake --install conda_build
3232
# ${CMAKE_ARGS} applys restrictions for CMake to search libs under conda building env.

docs/advanced/install.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ If DeePKS feature is required for [DeePKS-kit](https://github.com/deepmodeling/d
2626
- [Libnpy](https://github.com/llohse/libnpy/)
2727

2828
```bash
29-
cmake -B build -DENABLE_DEEPKS=1 -DTorch_DIR=~/libtorch/share/cmake/Torch/ -Dlibnpy_INCLUDE_DIR=~/libnpy/include
29+
cmake -B build -DENABLE_ML4DFT=1 -DTorch_DIR=~/libtorch/share/cmake/Torch/ -Dlibnpy_INCLUDE_DIR=~/libnpy/include
3030
```
3131

3232
> CMake will try to download Libnpy if it cannot be found locally.
@@ -208,6 +208,7 @@ CEREAL_DIR = /usr/local/include/cereal
208208
##------------------- OPTIONAL LIBS ---------------------------------
209209
## To use DEEPKS: set ENABLE_DEEPKS = ON, and set LIBTORCH_DIR and LIBNPY_DIR
210210
## To use MLKEDF: set ENABLE_MLKEDF = ON, and set LIBTORCH_DIR and LIBNPY_DIR
211+
211212
## To use LIBXC: set LIBXC_DIR which contains include and lib/libxc.a (>5.1.7)
212213
## To use DeePMD: set DeePMD_DIR LIBTORCH_DIR and TensorFlow_DIR
213214
## To use LibRI: set LIBRI_DIR and LIBCOMM_DIR

python/pyabacus/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ if(MKLROOT)
4444

4545
# Since libtorch will find its own MKL, the fftw part conflicts with the original one.
4646
# When enable deepks, mkl will be linked within ${TORCH_LIBRARIES}.
47-
if(NOT ENABLE_DEEPKS)
47+
if(NOT ENABLE_ML4DFT)
4848
list(APPEND math_libs IntelMKL::MKL)
4949
endif()
5050

0 commit comments

Comments
 (0)