remove unused code and redundancies

Author: Cstandardlib

source/module_hsolver/diago_bpcg.cpp

@@ -169,7 +169,6 @@ void DiagoBPCG<T, Device>::orth_projection(
         /*conj_x=*/false, /*conj_y=*/true, /*alpha=*/1.0, /*beta=*/0.0, /*Tensor out=*/&hsub_in);
     // hsub_in = ct::op::einsum("ij,kj->ik", grad_out, psi_in, option);
 
-    // this->orth_projection(this->psi, this->hsub, this->grad);
     // gemm: hsub_in(n_band x n_band) = psi_in^T(n_band x n_basis) * grad_out(n_basis x n_band)
     gemm_op()(this->ctx,
                 'C',
@@ -209,8 +208,7 @@ void DiagoBPCG<T, Device>::orth_projection(
                 grad_out.data<T>(),
                 this->n_basis);   //ldc
 
-    // * This type of non inner produce like operation does not need reduce!
-    // Parallel_Reduce::reduce_pool(grad_out.data<T>(), this->n_basis * this->n_band);
+    // * This type of non inner product like operation does not need reduce!
 
     return;
 }
@@ -225,8 +223,6 @@ void DiagoBPCG<T, Device>::rotate_wf(
         /*conj_x=*/false, /*conj_y=*/false, /*alpha=*/1.0, /*beta=*/0.0, /*Tensor out=*/&workspace_in);
     // workspace_in = ct::op::einsum("ij,jk->ik", hsub_in, psi_out, option);
 
-    // this->rotate_wf(hsub_out, psi_out, workspace_in);
-    // this->orth_cholesky(this->work, this->psi, this->hpsi, this->hsub);
     // gemm: workspace_in(n_basis x n_band) = psi_out(n_basis x n_band) * hsub_in(n_band x n_band)
     gemm_op()(this->ctx,
                 'N',
@@ -243,8 +239,7 @@ void DiagoBPCG<T, Device>::rotate_wf(
                 workspace_in.data<T>(),
                 this->n_basis);     //ldc
 
-    // * This type of non inner produce like operation does not need reduce!
-    // Parallel_Reduce::reduce_pool(workspace_in.data<T>(), this->n_basis * this->n_band);
+    // * This type of non inner product like operation does not need reduce!
 
     syncmem_complex_op()(psi_out.template data<T>(), workspace_in.template data<T>(), this->n_band * this->n_basis);
 

source/module_hsolver/diago_bpcg.h

@@ -340,6 +340,9 @@ class DiagoBPCG
     using resmem_complex_op = ct::kernels::resize_memory<T, ct_Device>;
     using syncmem_complex_op = ct::kernels::synchronize_memory<T, ct_Device, ct_Device>;
 
+    // note: these operators use template parameter base_device::Device_*
+    // defined in module_base/module_device/types.h
+    // different from ct_Device!
     using calc_grad_with_block_op = hsolver::calc_grad_with_block_op<T, Device>;
     using line_minimize_with_block_op = hsolver::line_minimize_with_block_op<T, Device>;
     using gemm_op = hsolver::gemm_op<T, Device>;