discourage part of the use of c-style array in psi initializer (#4866)

kirk0830 · web-flow · commit 53aa3871633f · 2024-08-02T16:00:09.000+08:00
diff --git a/source/module_psi/psi_initializer_nao.cpp b/source/module_psi/psi_initializer_nao.cpp
@@ -194,7 +194,7 @@ void psi_initializer_nao<T, Device>::read_external_orbs(std::string* orbital_fil
         this->n_rgrid_.resize(this->p_ucell_->ntype);
     }
 
-    int nchi[this->p_ucell_->ntype];
+    std::vector<int> nchi(this->p_ucell_->ntype);
     if (rank == 0)
     {
         for (int it = 0; it < this->p_ucell_->ntype; it++)
@@ -204,7 +204,7 @@ void psi_initializer_nao<T, Device>::read_external_orbs(std::string* orbital_fil
     }
 
     // bcast
-    Parallel_Common::bcast_int(nchi, this->p_ucell_->ntype);
+    Parallel_Common::bcast_int(nchi.data(), this->p_ucell_->ntype);
     // resize
     if (rank != 0)
     {

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ void psi_initializer_nao<T, Device>::read_external_orbs(std::string* orbital_fil`
`194`	`194`	`this->n_rgrid_.resize(this->p_ucell_->ntype);`
`195`	`195`	`}`
`196`	`196`
`197`		`- int nchi[this->p_ucell_->ntype];`
	`197`	`+ std::vector<int> nchi(this->p_ucell_->ntype);`
`198`	`198`	`if (rank == 0)`
`199`	`199`	`{`
`200`	`200`	`for (int it = 0; it < this->p_ucell_->ntype; it++)`
`@@ -204,7 +204,7 @@ void psi_initializer_nao<T, Device>::read_external_orbs(std::string* orbital_fil`
`204`	`204`	`}`
`205`	`205`
`206`	`206`	`// bcast`
`207`		`- Parallel_Common::bcast_int(nchi, this->p_ucell_->ntype);`
	`207`	`+ Parallel_Common::bcast_int(nchi.data(), this->p_ucell_->ntype);`
`208`	`208`	`// resize`
`209`	`209`	`if (rank != 0)`
`210`	`210`	`{`