Skip to content

Commit 8829fb6

Browse files
committed
change func in the elecstate_getter
1 parent 6a44de7 commit 8829fb6

File tree

4 files changed

+11
-21
lines changed

4 files changed

+11
-21
lines changed

source/module_elecstate/elecstate_getters.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,5 @@ int get_xc_func_type()
2525

2626

2727

28-
std::string get_ks_solver_type()
29-
{
30-
return PARAM.inp.ks_solver;
31-
}
3228

3329
} // namespace elecstate

source/module_elecstate/elecstate_getters.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,12 @@
77
namespace elecstate
88
{
99

10-
/// @brief get the value of GlobalC::ucell.omega
10+
/// @brief get the value of .omega
1111
double get_ucell_omega();
12-
/// @brief get the value of GlobalC::ucell.tpiba
12+
/// @brief get the value of .tpiba
1313
double get_ucell_tpiba();
1414
/// @brief get the value of XC_Functional::func_type
1515
int get_xc_func_type();
16-
/// @brief get the type of KS_SOLVER
17-
std::string get_ks_solver_type();
1816

1917
} // namespace elecstate
2018

source/module_elecstate/elecstate_print.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -447,7 +447,7 @@ void ElecState::print_etot(const UnitCell& ucell,
447447
{
448448
drho.push_back(scf_thr_kin);
449449
}
450-
elecstate::print_scf_iterinfo(get_ks_solver_type(),
450+
elecstate::print_scf_iterinfo(PARAM.inp.ks_solver,
451451
iter,
452452
6,
453453
mag,

source/module_elecstate/test/elecstate_print_test.cpp

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,7 @@ double get_ucell_tot_magnetization_nc_z()
5858
{
5959
return 5.5;
6060
}
61-
std::string tmp_ks_solver = "dav";
62-
std::string get_ks_solver_type()
63-
{
64-
return tmp_ks_solver;
65-
}
61+
6662
} // namespace elecstate
6763

6864
Charge::Charge()
@@ -264,31 +260,31 @@ TEST_F(ElecStatePrintTest, PrintEtot)
264260
std::vector<std::string> ks_solvers = {"cg", "lapack", "genelpa", "dav", "scalapack_gvx", "cusolver"};
265261
for (int i = 0; i < ks_solvers.size(); i++)
266262
{
267-
elecstate::tmp_ks_solver = ks_solvers[i];
263+
PARAM.input.ks_solver = ks_solvers[i];
268264
testing::internal::CaptureStdout();
269265
elecstate.print_etot(ucell,converged, iter, scf_thr, scf_thr_kin, duration, printe, pw_diag_thr, avg_iter, print);
270266
output = testing::internal::GetCapturedStdout();
271-
if (elecstate::tmp_ks_solver == "cg")
267+
if (PARAM.input.ks_solver == "cg")
272268
{
273269
EXPECT_THAT(output, testing::HasSubstr("CG"));
274270
}
275-
else if (elecstate::tmp_ks_solver == "lapack")
271+
else if (PARAM.input.ks_solver == "lapack")
276272
{
277273
EXPECT_THAT(output, testing::HasSubstr("LA"));
278274
}
279-
else if (elecstate::tmp_ks_solver == "genelpa")
275+
else if (PARAM.input.ks_solver == "genelpa")
280276
{
281277
EXPECT_THAT(output, testing::HasSubstr("GE"));
282278
}
283-
else if (elecstate::tmp_ks_solver == "dav")
279+
else if (PARAM.input.ks_solver == "dav")
284280
{
285281
EXPECT_THAT(output, testing::HasSubstr("DA"));
286282
}
287-
else if (elecstate::tmp_ks_solver == "scalapack_gvx")
283+
else if (PARAM.input.ks_solver == "scalapack_gvx")
288284
{
289285
EXPECT_THAT(output, testing::HasSubstr("GV"));
290286
}
291-
else if (elecstate::tmp_ks_solver == "cusolver")
287+
else if (PARAM.input.ks_solver == "cusolver")
292288
{
293289
EXPECT_THAT(output, testing::HasSubstr("CU"));
294290
}

0 commit comments

Comments
 (0)