ouch, the constexpr of std::array::size() is of C++17

Author: kirk0830

deps/LibComm

@@ -0,0 +1 @@
+Subproject commit ec984514b44480e98bd1578bcacca7a19c849724

deps/LibRI

@@ -0,0 +1 @@
+Subproject commit bd299faeaa184b912e4bdf5c0e182dfb7f47272a

source/module_io/read_input.cpp

@@ -7,6 +7,7 @@
 #include <sstream>
 #include <array>
 #include <vector>
+#include <cassert>
 #include "module_base/formatter.h"
 #include "module_base/global_file.h"
 #include "module_base/global_function.h"
@@ -20,14 +21,18 @@ std::string longstring(const std::vector<std::string>& words)
     return FmtCore::join(" ", words);
 }
 
-bool assume_bool(const std::string& val)
+bool assume_as_boolean(const std::string& val)
 {
     const std::string val_ = FmtCore::lower(val);
 
     const std::array<std::string, 7> t_ = {"true", "1", "t", "yes", "y", "on", ".true."};
     const std::array<std::string, 7> f_ = {"false", "0", "f", "no", "n", "off", ".false."};
     // This will work because std::array<T, N>::size() is a constexpr function
-    static_assert(t_.size() == f_.size(), "t_ and f_ must have the same lengths");
+    // Ouch it is of C++17 standard...
+    // static_assert(t_.size() == f_.size(), "t_ and f_ must have the same lengths");
+#ifdef __DEBUG // C++11 can do this
+    assert(t_.size() == f_.size());
+#endif
 
     if (std::find(t_.begin(), t_.end(), val_) != t_.end())
     {

source/module_io/read_input.h

@@ -142,7 +142,7 @@ class ReadInput
 // convert string vector to a long string
 std::string longstring(const std::vector<std::string>& str_values);
 // convert string to bool
-bool assume_bool(const std::string& val);
+bool assume_as_boolean(const std::string& val);
 // convert to directory format
 std::string to_dir(const std::string& str);
 // return a warning string if the string is not found in the vector

source/module_io/read_input_item_output.cpp

@@ -101,7 +101,7 @@ void ReadInput::item_output()
             {
                 ModuleBase::WARNING_QUIT("ReadInput", "out_band should have 1 or 2 values");
             }
-            para.input.out_band[0] = assume_bool(item.str_values[0]);
+            para.input.out_band[0] = assume_as_boolean(item.str_values[0]);
             para.input.out_band[1] = (count == 2) ? std::stoi(item.str_values[1]) : 8;
         };
         item.reset_value = [](const Input_Item& item, Parameter& para) {
@@ -236,7 +236,7 @@ void ReadInput::item_output()
             {
                 ModuleBase::WARNING_QUIT("ReadInput", "out_mat_hs should have 1 or 2 values");
             }
-            para.input.out_mat_hs[0] = assume_bool(item.str_values[0]);
+            para.input.out_mat_hs[0] = assume_as_boolean(item.str_values[0]);
             para.input.out_mat_hs[1] = (count == 2) ? std::stoi(item.str_values[1]) : 8;
         };
         item.reset_value = [](const Input_Item& item, Parameter& para) {
@@ -257,7 +257,7 @@ void ReadInput::item_output()
             {
                 ModuleBase::WARNING_QUIT("ReadInput", "out_mat_tk should have 1 or 2 values");
             }
-            para.input.out_mat_tk[0] = assume_bool(item.str_values[0]);
+            para.input.out_mat_tk[0] = assume_as_boolean(item.str_values[0]);
             para.input.out_mat_tk[1] = (count == 2) ? std::stoi(item.str_values[1]) : 8;
         };
         sync_intvec(input.out_mat_tk, 2, 0);

source/module_io/read_input_tool.h

@@ -8,7 +8,7 @@
 #define strvalue item.str_values[0]
 #define intvalue std::stoi(item.str_values[0])
 #define doublevalue std::stod(item.str_values[0])
-#define boolvalue assume_bool(item.str_values[0])
+#define boolvalue assume_as_boolean(item.str_values[0])
 
 #ifdef __MPI
 #define add_double_bcast(PARAMETER)                                                                                    \