Refactor: Remove final_scf

Author: Flying-dragon-boxing

source/module_cell/k_vector_utils.cpp

@@ -77,7 +77,7 @@ void k_vec_c2d(K_Vectors& kv, const ModuleBase::Matrix3& latvec)
 
 void set_both_kvec(K_Vectors& kv, const ModuleBase::Matrix3& G, const ModuleBase::Matrix3& R, std::string& skpt)
 {
-    if (PARAM.inp.final_scf) // Todo: Any way to avoid directly using input variables?
+    if (true) // Originally GlobalV::FINAL_SCF, but we don't have this variable in the new code.
     {
         if (kv.k_nkstot == 0)
         {

source/module_cell/test/klist_test.cpp

@@ -650,7 +650,7 @@ TEST_F(KlistTest, SetBothKvecFinalSCF)
     kv->kvec_c[0].y = 0.0;
     kv->kvec_c[0].z = 0.0;
     std::string skpt;
-    PARAM.input.final_scf = true;
+//    PARAM.input.final_scf = true;
     kv->kd_done = false;
     kv->kc_done = false;
     // case 1
@@ -697,7 +697,7 @@ TEST_F(KlistTest, SetBothKvec)
     kv->kc_done = false;
     kv->kd_done = true;
     std::string skpt;
-    PARAM.input.final_scf = false;
+//    PARAM.input.final_scf = false;
 //    kv->set_both_kvec(ucell.G, ucell.latvec, skpt);
     KVectorUtils::set_both_kvec(*kv, ucell.G, ucell.latvec, skpt);
     EXPECT_TRUE(kv->kc_done);

source/module_parameter/input_parameter.h

@@ -115,7 +115,7 @@ struct Input_para
     double scf_thr = -1.0;     ///< \sum |rhog_out - rhog_in |^2
     double scf_ene_thr = -1.0; ///< energy threshold for scf convergence, in eV
     int scf_thr_type = -1;     ///< type of the criterion of scf_thr, 1: reci drho, 2: real drho
-    bool final_scf = false;    ///< whether to do final scf
+//    bool final_scf = false;    ///< whether to do final scf
     bool scf_os_stop = false;  ///< whether to stop scf when oscillation is detected
     double scf_os_thr = -0.01; ///< drho threshold for oscillation
     int scf_os_ndim = 0;       ///< number of old iterations used for oscillation detection