Perf: minor optimization in module_lr #5435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maki49
force-pushed
the
develop
branch
3 times, most recently
from
eca6dad to
90fadcd
Compare
maki49
force-pushed
the
develop
branch
2 times, most recently
from
6608bbd to
6225505
Compare
mohanchen
reviewed
Nov 8, 2024
Collaborator
|
‘lr' should not be a special case that appears in deciding the name of running log. This is not a good enough design. I would suggest the developer to think a more appropriate way to implement the function. |
Collaborator
Author
I've changed the code to the new solution to avoid log-coverage: if |
mohanchen
approved these changes
Nov 13, 2024
Fisherd99
pushed a commit
to Fisherd99/abacus-BSE
that referenced
this pull request
Mar 31, 2025
* fix the waste of memory in matsym * output to running_nscf.log for lr * remove a useless line in op_lr_diag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LR_Util::matsym