Skip to content

Fix: Compiling error for ROCM #5464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2024
Merged

Fix: Compiling error for ROCM #5464

merged 2 commits into from
Nov 13, 2024

Conversation

@dyzheng
Copy link
Collaborator

@dyzheng dyzheng commented Nov 12, 2024

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #5414

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@dyzheng
Copy link
Collaborator Author

dyzheng commented Nov 12, 2024

img_v3_02gi_b08602e2-149d-45d5-9c65-26014eb6b8ag
@Qianruipku still error after this PR

@mohanchen mohanchen added the GPU & DCU & HPC GPU and DCU and HPC related any issues label Nov 13, 2024
@mohanchen mohanchen merged commit 9718c41 into deepmodeling:develop Nov 13, 2024
14 checks passed
Fisherd99 pushed a commit to Fisherd99/abacus-BSE that referenced this pull request Mar 31, 2025
@dyzheng @Fisherd99
Fix: Compiling error for ROCM (deepmodeling#5464)
5efc749 
* Fix: compiling error for ROCM

* Fix: compiling error of DCU

---------

Co-authored-by: dyzheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohanchen mohanchen mohanchen approved these changes

Assignees

No one assigned

Labels

GPU & DCU & HPC GPU and DCU and HPC related any issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Daily DCU test failed since 20241102

2 participants

@dyzheng @mohanchen