Refactor:remove GlobalC::ucell in module_elesctate #5730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohanchen
approved these changes
Dec 16, 2024
Collaborator
|
Good job. |
Fisherd99
pushed a commit
to Fisherd99/abacus-BSE
that referenced
this pull request
Mar 31, 2025
* change ucell in elecstate_energy * fix bug in elesctate_energy * change ucell in set-rho_core * change ucell in elecstate.cpp * change ucell in charge_mixing * change ucell in prepare in H_TDDFT_pw.cpp * change ucell in set_nonlocal.cpp * change ucell in ucell_getters.cpp * change elecstate_getter * change PARAM.inp.vdw_method in the elecstate_print * change ucell in charge_mixing * change get ucell tpiba in getters * [pre-commit.ci lite] apply automatic fixes * change ucell test file * update value of omega and tpiba in charge_mixing * update get ucell oemga * change ucell in the charge * fix bug in charge * fix bug in set_omega --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit Tests and/or Case Tests for my changes
What's changed?