Refactor: remove the Psi Constructors using int* ngk_in
#5745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haozhihan
changed the title
haozhihan
changed the title
int* ngk_in
Author
Author
|
This PR is the first step of using vector to replace Since directly replacing all So, first sort out, summarize and replace all constructors that use |
mohanchen
approved these changes
Dec 24, 2024
Fisherd99
pushed a commit
to Fisherd99/abacus-BSE
that referenced
this pull request
Mar 31, 2025
…ng#5745) * delete Psi(const int* ngk_in); * [pre-commit.ci lite] apply automatic fixes * format psi class * update hsolverpw * [pre-commit.ci lite] apply automatic fixes * add Constructor 8-2 * remove useless code * update operator.cpp call_act func * [pre-commit.ci lite] apply automatic fixes * change test code for psi Constructor * fix unit test bug * remove useless code --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.