Skip to content

Conversation

@19hello
Copy link
Collaborator

@19hello 19hello commented Mar 11, 2025

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@Flying-dragon-boxing
Copy link
Collaborator

Any difference between #5997 and #5977?

@19hello
Copy link
Collaborator Author

19hello commented Mar 11, 2025

Any difference between #5997 and #5977?

I mistakenly pushed the wrong branch in #5977 . #5977 was the branch I previously used for submitting BFGS, the current branch is a new branch for submitting LBFGS.

@mohanchen mohanchen added Features Needed The features are indeed needed, and developers should have sophisticated knowledge GeometryRelaxation Issues related to geometry relaxation labels Mar 11, 2025
@19hello 19hello closed this Mar 12, 2025
@19hello 19hello reopened this Mar 12, 2025
@19hello 19hello closed this Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Features Needed The features are indeed needed, and developers should have sophisticated knowledge GeometryRelaxation Issues related to geometry relaxation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants