Skip to content

Conversation

@mohanchen
Copy link
Collaborator

Update the output and readin of electronic wave functions in plane wave basis set

@mohanchen mohanchen requested a review from AsTonyshment May 17, 2025 09:18
@mohanchen mohanchen added Input&Output Suitable for coders without knowing too many DFT details The Absolute Zero Reduce the "entropy" of the code to 0 Unit Tests/Integreate Tests Issues/PR related to unit tests and integrate tests labels May 17, 2025
Copy link
Collaborator

@AsTonyshment AsTonyshment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the source/Makefile.Objects file needs to be modified as well to let the makefile test pass. Adding filename.o\ to the OBJS_IO list might be worth a shot .

@AsTonyshment AsTonyshment self-requested a review May 19, 2025 01:47
Copy link
Collaborator

@AsTonyshment AsTonyshment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mohanchen mohanchen merged commit f158182 into deepmodeling:develop May 19, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Input&Output Suitable for coders without knowing too many DFT details The Absolute Zero Reduce the "entropy" of the code to 0 Unit Tests/Integreate Tests Issues/PR related to unit tests and integrate tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants