Skip to content

Fix: Fix calculation type inconsistency across MPI ranks, so that the log file names are correct when out_alllog = 1 #6356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

Fix: Fix calculation type inconsistency across MPI ranks, so that the log file names are correct when out_alllog = 1 #6356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions source/source_io/read_set_globalv.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,17 +126,22 @@ void ReadInput::set_global_dir(const Input_para& inp, System_para& sys)

// set the global log file
bool out_alllog = inp.out_alllog;
// set the global calculation type
std::string cal_type = inp.calculation;
#ifdef __MPI
// because log_file is different for each rank, so we need to bcast the out_alllog
Parallel_Common::bcast_bool(out_alllog);
// In `ReadInput::read_parameters`, `bcastfunc(param)` is after `set_global_dir`,
// so `cal_type` must be synchronized here manually
Parallel_Common::bcast_string(cal_type);
#endif
if (out_alllog)
{
PARAM.sys.log_file = "running_" + PARAM.inp.calculation + "_" + std::to_string(PARAM.sys.myrank + 1) + ".log";
PARAM.sys.log_file = "running_" + cal_type + "_" + std::to_string(PARAM.sys.myrank + 1) + ".log";
}
else
{
PARAM.sys.log_file = "running_" + PARAM.inp.calculation + ".log";
PARAM.sys.log_file = "running_" + cal_type + ".log";
}
#ifdef __MPI
Parallel_Common::bcast_string(sys.global_in_card);
Expand Down
Loading