upgrade os.system to subporcess.popen method (#1066)

* upgrade os.system to subporcess-popen method

* fix UT error

* fix UT error

* address comments

Author: denghuilu

source/tests/test_model_compression.py

@@ -1,6 +1,7 @@
 import os,sys,platform,shutil,dpdata,json
 import numpy as np
 import unittest
+import subprocess as sp
 
 from deepmd.infer import DeepPot
 from deepmd.env import MODEL_VERSION
@@ -17,6 +18,16 @@ def _file_delete(file) :
     if os.path.exists(file):
         os.remove(file)
 
+def _subprocess_run(command):
+    popen = sp.Popen(command.split(), shell=False, stdout=sp.PIPE, stderr=sp.STDOUT)
+    for line in iter(popen.stdout.readline, b''):
+        if hasattr(line, 'decode'):
+            line = line.decode('utf-8')
+        line = line.rstrip()
+        print(line)
+    popen.wait()
+    return popen.returncode
+
 def _init_models():
     data_file  = str(tests_path / os.path.join("model_compression", "data"))
     frozen_model = str(tests_path / "dp-original.pb")
@@ -28,12 +39,12 @@ def _init_models():
     with open(INPUT, "w") as fp:
         json.dump(jdata, fp, indent=4)
 
-    ret = os.system("dp train " + INPUT)
-    assert(ret == 0), "DP train error!"
-    ret = os.system("dp freeze -o " + frozen_model)
-    assert(ret == 0), "DP freeze error!"
-    ret = os.system("dp compress " + " -i " + frozen_model + " -o " + compressed_model)
-    assert(ret == 0), "DP model compression error!"
+    ret = _subprocess_run("dp train " + INPUT)
+    np.testing.assert_equal(ret, 0, 'DP train failed!')
+    ret = _subprocess_run("dp freeze -o " + frozen_model)
+    np.testing.assert_equal(ret, 0, 'DP freeze failed!')
+    ret = _subprocess_run("dp compress " + " -i " + frozen_model + " -o " + compressed_model)
+    np.testing.assert_equal(ret, 0, 'DP model compression failed!')
     return INPUT, frozen_model, compressed_model
 
 INPUT, FROZEN_MODEL, COMPRESSED_MODEL = _init_models()

source/tests/test_transfer.py

@@ -1,6 +1,7 @@
 import os,sys,platform,shutil,dpdata,json
 import numpy as np
 import unittest
+import subprocess as sp
 
 from deepmd.env import tf
 from deepmd.infer import DeepPot
@@ -18,6 +19,16 @@ def _file_delete(file) :
     if os.path.exists(file):
         os.remove(file)
 
+def _subprocess_run(command):
+    popen = sp.Popen(command.split(), shell=False, stdout=sp.PIPE, stderr=sp.STDOUT)
+    for line in iter(popen.stdout.readline, b''):
+        if hasattr(line, 'decode'):
+            line = line.decode('utf-8')
+        line = line.rstrip()
+        print(line)
+    popen.wait()
+    return popen.returncode
+
 class TestTransform(unittest.TestCase) :
     @classmethod
     def setUpClass(self):
@@ -26,8 +37,8 @@ def setUpClass(self):
         self.new_model = str(tests_path / "dp-new.pb")
         convert_pbtxt_to_pb(str(tests_path / os.path.join("infer","deeppot.pbtxt")), self.old_model)
         convert_pbtxt_to_pb(str(tests_path / os.path.join("infer","deeppot-1.pbtxt")), self.raw_model)
-        ret = os.system("dp transfer -O " + self.old_model + " -r " + self.raw_model + " -o " + self.new_model)
-        assert(ret == 0), "DP transfer error!"
+        ret = _subprocess_run("dp transfer -O " + self.old_model + " -r " + self.raw_model + " -o " + self.new_model)
+        np.testing.assert_equal(ret, 0, 'DP transfer failed!')
 
         self.dp = DeepPot(self.new_model)
         self.coords = np.array([12.83, 2.56, 2.18,