You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
feat: add cspell configuration and CI spell-check (#11)
* feat: add cspell configuration and CI spell-check
* fix: add jlpm install step to spell-check CI job
* fix: revert incorrect build.yml changes - Base Setup doesn't provide jlpm
The previous commit attempted to add a 'Install dependencies' step using jlpm,
but jlpm is not available after Base Setup alone. The correct fix requires
updating yarn.lock locally with the cspell dependency, which is blocked by
missing GITHUB_TOKEN in the development environment.
This commit reverts the incorrect build.yml changes. The spell-check job
still needs yarn.lock to be updated with the [email protected] dependency.
* fix: move spell check from build.yml to ci.yaml as separate CI workflow
* fix: add jlpm install step before spell-check in CI
The spell-check job was failing with 'jlpm: command not found' because
the Base Setup action provides the jlpm binary but doesn't install
node_modules. This adds the missing install step with GITHUB_TOKEN.
* fix: use jlpm instead of jlpm install in CI spell-check job
The jlpm command without arguments automatically runs yarn install.
This matches the pattern used in build.yml and fixes the 'jlpm: command not found' error.
* fix: install jupyterlab to provide jlpm command in spell-check CI
The Base Setup action provides Python and yarn but not jlpm. Installing
jupyterlab via pip provides the jlpm command, following the pattern used
in build.yml.
* fix: use npx cspell instead of adding to devDependencies
- Avoids yarn.lock sync issue that causes CI failure
- npx downloads cspell on-the-fly without requiring it in package.json
- Fixes 'YN0028: The lockfile would have been modified' error
* fix: add JupyterLab technical terms to cspell dictionary
Add 22 technical terms found in spell check CI logs:
- JupyterLab packages: apputils, coreutils, settingregistry, lumino, testutils
- Notebook formats: nbformat, ipynb
- Build tools: jlpm, pyproject, sdist, bdist, lintcache, stylelintcache, csstree
- Test tools: pytest, Pytest, codegen
- Library names: chakra, ydoc
- Config: jpserver, venv, labextensions
- Author names: Jakubowski, rseidelsohn
* chore: cr feedback
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* fix: add --frozen-lockfile flag to jlpm install in CI
Ensures dependencies are installed exactly as specified in yarn.lock
without modifications during CI runs.
* fix: remove unnecessary dependencies install step from spell check
The spell check uses npx cspell which doesn't require project
dependencies to be installed. The jlpm install step was causing
authentication failures when trying to fetch @deepnote/blocks.
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
0 commit comments