fix: re-add notebook switching #5

andyjakubowski · 2025-10-09T14:08:19Z

Signed-off-by: Andy Jakubowski [email protected]

Summary by CodeRabbit

Bug Fixes
- Prevents crashes and incorrect updates when notebook metadata is invalid.
- Ensures notebook list renders reliably; shows empty state when none are available.
- Applies notebook changes only when a valid selection exists.
Improvements
- More robust validation of notebook data for safer loading and rendering.
- Smoother defaults for new/blank notebooks to avoid null metadata issues.
- Enhanced compatibility with multiple notebooks, preserving names, cells, and version info during load.

Signed-off-by: Andy Jakubowski <[email protected]>

linear · 2025-10-09T14:08:23Z

GRN-4910 Re-add notebook switching

Need to redo this after switching from Python to TypeScript conversion of .deepnote <> .ipynb

coderabbitai · 2025-10-09T14:08:57Z

📝 Walkthrough

Walkthrough

Introduces zod-based runtime validation for Deepnote metadata via deepnoteMetadataSchema.safeParse in NotebookPicker change and render paths.
NotebookPicker handleChange now aborts on invalid metadata; on valid metadata, uses validated notebooks map to update the model with cells, nbformat, nbformat_minor, and metadata.deepnote.notebooks.
NotebookPicker render validates metadata and derives notebook names from the validated notebooks map; otherwise renders empty options.
Deepnote content provider renames the schema to deepnoteFileFromServerSchema; validation and error handling remain the same; still transforms validated content.
Transformer now constructs a notebooks map, returns content with cells, metadata.deepnote.notebooks, and nbformat fields.
Types updated: adds deepnoteMetadataSchema, shifts metadata to a typed notebooks map, and introduces IDeepnoteNotebookContent.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as User
  participant NP as NotebookPicker
  participant Z as deepnoteMetadataSchema
  participant M as Notebook Model

  U->>NP: Select notebook (handleChange)
  NP->>Z: safeParse(metadata.deepnote)
  alt Metadata invalid
    Z-->>NP: failure
    NP->>NP: log error, abort
  else Metadata valid
    Z-->>NP: success (notebooks map)
    NP->>NP: lookup selected in notebooks
    alt Selected exists
      NP->>M: fromJSON({ cells, nbformat, nbformat_minor, metadata.deepnote.notebooks })
    else No selection
      NP->>NP: no-op
    end
  end

sequenceDiagram
  autonumber
  participant NP as NotebookPicker (render)
  participant Z as deepnoteMetadataSchema

  NP->>Z: safeParse(metadata.deepnote)
  alt Valid
    Z-->>NP: notebooks map
    NP->>NP: derive names for UI list
  else Invalid
    Z-->>NP: failure
    NP->>NP: render empty list
  end

sequenceDiagram
  autonumber
  participant S as Server (Deepnote YAML)
  participant CP as deepnote-content-provider
  participant SZ as deepnoteFileFromServerSchema
  participant T as transform-deepnote-yaml-to-notebook-content
  participant M as Notebook Model

  S-->>CP: content (YAML-derived JSON)
  CP->>SZ: safeParse(content)
  alt Invalid content
    SZ-->>CP: failure
    CP->>M: set model.content.cells = []
    CP-->>M: return model
  else Valid content
    SZ-->>CP: validatedModelContent
    CP->>T: transform(validatedModelContent)
    T-->>CP: { cells, metadata.deepnote.notebooks, nbformat, nbformat_minor }
    CP->>M: update model.content
  end

sequenceDiagram
  autonumber
  participant T as Transformer
  participant F as deepnoteFile
  participant C as Converter

  T->>F: read project.notebooks[]
  loop Build notebooks map
    T->>C: convertDeepnoteBlockToJupyterCell(block)
    C-->>T: cell
    T->>T: accumulate { id, name, cells[] } by notebook.id
  end
  alt Selected notebook found
    T-->>T: prepare cells from selected
    T-->>Caller: { cells, metadata.deepnote.notebooks, nbformat, nbformat_minor }
  else None found
    T-->>Caller: { cells:[code cell "No notebooks found"], metadata.deepnote.notebooks, nbformat, nbformat_minor }
  end

Pre-merge checks

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title “fix: re-add notebook switching” succinctly captures the primary change of restoring notebook switching functionality through metadata validation and model updates, making it clear and directly related to the core update in the changeset. It is concise, specific, and free of extraneous details.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 45fb503 and f47ba96.

📒 Files selected for processing (5)

src/components/NotebookPicker.tsx (3 hunks)
src/deepnote-content-provider.ts (3 hunks)
src/fallback-data.ts (1 hunks)
src/transform-deepnote-yaml-to-notebook-content.ts (3 hunks)
src/types.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (5)