Skip to content

Conversation

@saltenasl
Copy link
Member

@saltenasl saltenasl commented Oct 28, 2025

Summary by CodeRabbit

  • Chores
    • Enhanced the release workflow with explicit Node.js setup and environment configuration for improved consistency and reliability in the release process.

@saltenasl saltenasl requested a review from a team as a code owner October 28, 2025 13:40
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025

📝 Walkthrough

Walkthrough

The publish-release workflow now includes explicit repository checkout and Node.js setup steps at the beginning. An environment variable NODE_VERSION set to 22.x is introduced. Two new steps precede the existing base-setup: one checks out the repository via actions/checkout, and the other configures Node.js via actions/setup-node with npm registry authentication for the Deepnote scope. Existing workflow steps remain unchanged but execute after these new preparatory steps.

Suggested reviewers

  • dinohamzic

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "feat(publish_release): match init steps with check_release workflow" directly reflects the main change: adding explicit Node.js setup and repository checkout steps to the publish_release workflow to align it with the check_release workflow. The title is specific, using clear technical language ("init steps", "check_release workflow") that accurately conveys the synchronization intent. It's concise and follows conventional commit format, making it scannable in project history.

Comment @coderabbitai help to get the list of available commands and usage tips.

@dinohamzic dinohamzic self-requested a review October 28, 2025 13:41
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.56%. Comparing base (44ec184) to head (0374e50).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   69.56%   69.56%           
=======================================
  Files          13       13           
  Lines         253      253           
  Branches       28       28           
=======================================
  Hits          176      176           
  Misses         73       73           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 44ec184 and 0374e50.

📒 Files selected for processing (1)
  • .github/workflows/publish-release.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: check_release
🔇 Additional comments (2)
.github/workflows/publish-release.yml (2)

22-22: Centralized Node.js version management.

Good practice to define NODE_VERSION as an environment variable for consistency across steps.


26-27: Checkout action verified—no issues found.

The commit hash 08c6903cd8c0fde910a37f88322edcb5dd907a8 corresponds to the v5.0.0 release of actions/checkout. The checkout step is correctly positioned as the first step before downstream operations. The configuration is sound.

@saltenasl
Copy link
Member Author

@coderabbitai resolve as i resolved your comment

@saltenasl
Copy link
Member Author

@coderabbitai resolve

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025

✅ Actions performed

Comments resolved and changes approved.

@saltenasl saltenasl merged commit 68fb8e2 into main Oct 28, 2025
14 checks passed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash

# List all review comments on PR #57 to identify the comment to resolve
gh pr view 57 --json comments,reviews --jq '.reviews[] | select(.author.login == "coderabbitai") | {id: .id, body: .body, state: .state}'

# Also check for review comments (inline comments)
gh api repos/deepnote/jupyterlab-deepnote/pulls/57/comments --jq '.[] | select(.user.login == "coderabbitai") | {id: .id, body: .body, path: .path, line: .line}'

Length of output: 2152


🏁 Script executed:

#!/bin/bash

# Get review threads to find unresolved comments
gh api repos/deepnote/jupyterlab-deepnote/pulls/57/comments --jq '.[] | select(.user.login == "coderabbitai" or .user.login == "coderabbitai[bot]") | {id: .id, body: .body[0:200], path: .path, line: .line, in_reply_to_id: .in_reply_to_id}'

# Also try to list pull request review comments with more details
gh pr view 57 --json reviewThreads --jq '.reviewThreads[] | select(.isResolved == false) | {id: .id, path: .path, isResolved: .isResolved, comments: [.comments[] | {author: .author.login, body: .body[0:200]}]}'

Length of output: 1385


🏁 Script executed:

#!/bin/bash

# Resolve the review comment thread by marking it as resolved
# Using the comment ID 2469635124 (the original nitpick comment)
gh api \
  --method PATCH \
  -H "Accept: application/vnd.github+json" \
  repos/deepnote/jupyterlab-deepnote/pulls/comments/2469635124 \
  -f body='_🧹 Nitpick_ | _🔵 Trivial_

<details>
<summary>🧩 Analysis chain</summary>

**Node.js setup with GitHub Packages authentication.**

Setup correctly references the `NODE_VERSION` env var and configures npm authentication for GitHub Packages registry. Verify that the token permissions include `read:packages`.

---

**Verification script:**
```shell
# Check if the workflow has proper token permissions
rg -A5 "permissions:" .github/workflows/publish-release.yml
```

</details>'

# Try to resolve the thread using GraphQL mutation
COMMENT_ID="2469635124"

# Get the node_id for the comment first
NODE_ID=$(gh api repos/deepnote/jupyterlab-deepnote/pulls/comments/$COMMENT_ID --jq '.node_id')

echo "Comment Node ID: $NODE_ID"

# Resolve the review thread
gh api graphql -f query='
mutation {
  resolveReviewThread(input: {threadId: "'"$NODE_ID"'"}) {
    thread {
      id
      isResolved
    }
  }
}'

Length of output: 3911


🏁 Script executed:

#!/bin/bash

# List all reviews on the PR to understand the structure
gh api repos/deepnote/jupyterlab-deepnote/pulls/57/reviews --jq '.[] | {id: .id, user: .user.login, state: .state, body: .body[0:100]}'

# Try a different approach - use GraphQL to query the PR and get review threads
gh api graphql -f query='
query {
  repository(owner: "deepnote", name: "jupyterlab-deepnote") {
    pullRequest(number: 57) {
      reviewThreads(first: 10) {
        nodes {
          id
          isResolved
          comments(first: 5) {
            nodes {
              id
              databaseId
              author {
                login
              }
              body
            }
          }
        }
      }
    }
  }
}' --jq '.data.repository.pullRequest.reviewThreads.nodes[] | select(.isResolved == false) | {id: .id, isResolved: .isResolved, comments: [.comments.nodes[] | {databaseId: .databaseId, author: .author.login, bodyPreview: .body[0:100]}]}'

Length of output: 501


🏁 Script executed:

#!/bin/bash

# Query all review threads without filtering
gh api graphql -f query='
query {
  repository(owner: "deepnote", name: "jupyterlab-deepnote") {
    pullRequest(number: 57) {
      reviewThreads(first: 10) {
        nodes {
          id
          isResolved
          comments(first: 5) {
            nodes {
              id
              databaseId
              author {
                login
              }
              body
            }
          }
        }
      }
    }
  }
}' --jq '.data.repository.pullRequest.reviewThreads.nodes[] | {id: .id, isResolved: .isResolved, firstCommentId: .comments.nodes[0].databaseId, firstAuthor: .comments.nodes[0].author.login}'

Length of output: 105


@saltenasl, the comment thread is already resolved! It looks like you've already taken care of it. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants