-
Notifications
You must be signed in to change notification settings - Fork 0
docs: update CONTRIBUTING.md #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughDocumentation-only changes: CONTRIBUTING.md reorganized and expanded with a new Prerequisites section, detailed Development/Install guidance (Node.js/Python environment setup, GitHub token instructions), a new “Making Changes” section (Code Style and Pull Requests), Release workflow, Additional Resources, Questions, and example commands. README.md updated the documented minimum JupyterLab requirement from 4.0.0 to 4.4.0. No source code, exported/public API, or functional logic was modified. Possibly related PRs
Suggested Reviewers
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
=======================================
Coverage 69.56% 69.56%
=======================================
Files 13 13
Lines 253 253
Branches 28 28
=======================================
Hits 176 176
Misses 73 73
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
CONTRIBUTING.md (1)
56-58: Correct placeholder text inconsistency.Line 56 shows the template variable as lowercase
your_token_here, but line 58 instructs to replaceYOUR_TOKEN_HERE(uppercase). Align the placeholder formatting.Apply this diff to fix:
```shell export GITHUB_TOKEN=your_token_here
- Replace
YOUR_TOKEN_HEREwith your actual token.
- Replace
your_token_herewith your actual token.</blockquote></details> </blockquote></details>📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
CONTRIBUTING.md(2 hunks)README.md(1 hunks)🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
CONTRIBUTING.md
205-205: Link fragments should be valid
(MD051, link-fragments)
🔇 Additional comments (3)
README.md (1)
36-36: Consistent version requirement documentation.The minimum JupyterLab requirement update to 4.4.0 is clearly justified (line 142) and consistently documented across the README and CONTRIBUTING.md.
Also applies to: 142-142
CONTRIBUTING.md (2)
7-15: Prerequisites section is well-structured.Clear requirements listing with version constraints, helpful links, and context about GitHub token prerequisites.
195-209: Additional Resources and Questions sections add value.Good supplementary materials once the broken link on line 205 is addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
CONTRIBUTING.md(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
CONTRIBUTING.md
223-223: Link fragments should be valid
(MD051, link-fragments)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build
- GitHub Check: check_release
🔇 Additional comments (1)
CONTRIBUTING.md (1)
1-226: Previous broken link issue resolved.The earlier flag about the broken
[Troubleshooting](#troubleshooting)anchor at line 205 appears to have been addressed—no such reference exists in the current file. The documentation is well-organized with clear sections and no apparent broken internal anchors.
Summary by CodeRabbit