Skip to content

fix(ui): fix toolbar layout on file load #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 16, 2025
Merged

fix(ui): fix toolbar layout on file load #31

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5393cb3
fix(ui): fix toolbar layout on file load
andyjakubowski Oct 15, 2025
05f7a51
Merge branch 'main' into andy/grn-4946-fix-toolbar-layout-on-file-load
andyjakubowski Oct 16, 2025
38d4300
Add tests to NotebookPicker
andyjakubowski Oct 16, 2025
15169a0
Update cspell, formatting
andyjakubowski Oct 16, 2025
02c7ee0
Fix test
andyjakubowski Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/components/NotebookPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import { ReactWidget } from '@jupyterlab/apputils';
import { NotebookPanel } from '@jupyterlab/notebook';
import { HTMLSelect } from '@jupyterlab/ui-components';
import { deepnoteMetadataSchema } from '../types';
import { Widget } from '@lumino/widgets';
import { Message, MessageLoop } from '@lumino/messaging';

export class NotebookPicker extends ReactWidget {
private selected: string | null = null;
Expand Down Expand Up @@ -63,6 +65,13 @@ export class NotebookPicker extends ReactWidget {
this.update();
};

protected onAfterAttach(msg: Message): void {
super.onAfterAttach(msg);
requestAnimationFrame(() => {
MessageLoop.sendMessage(this.parent!, Widget.ResizeMessage.UnknownSize);
});
}
Comment on lines +68 to +73
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Guard against null parent.

this.parent! will throw if no parent exists at attach time. Add a null check.

 protected onAfterAttach(msg: Message): void {
   super.onAfterAttach(msg);
   requestAnimationFrame(() => {
-    MessageLoop.sendMessage(this.parent!, Widget.ResizeMessage.UnknownSize);
+    if (this.parent) {
+      MessageLoop.sendMessage(this.parent, Widget.ResizeMessage.UnknownSize);
+    }
   });
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
protected onAfterAttach(msg: Message): void {
super.onAfterAttach(msg);
requestAnimationFrame(() => {
MessageLoop.sendMessage(this.parent!, Widget.ResizeMessage.UnknownSize);
});
}
protected onAfterAttach(msg: Message): void {
super.onAfterAttach(msg);
requestAnimationFrame(() => {
if (this.parent) {
MessageLoop.sendMessage(this.parent, Widget.ResizeMessage.UnknownSize);
}
});
}
🤖 Prompt for AI Agents 
In src/components/NotebookPicker.tsx around lines 68 to 73, the code uses a
non-null assertion this.parent! when sending a resize message which will throw
if parent is null; update the method to check that this.parent is non-null
before calling MessageLoop.sendMessage (e.g., if (this.parent) {
MessageLoop.sendMessage(this.parent, Widget.ResizeMessage.UnknownSize); }) and
remove the non-null assertion so the resize is only sent when a parent exists.


render(): JSX.Element {
const deepnoteMetadata = this.panel.context.model.getMetadata('deepnote');

Expand All @@ -81,7 +90,7 @@ export class NotebookPicker extends ReactWidget {
aria-label="Select active notebook"
title="Select active notebook"
style={{
maxWidth: '120px',
width: '120px',
textOverflow: 'ellipsis',
whiteSpace: 'nowrap',
overflow: 'hidden'
Expand Down
Loading