Skip to content

Commit 0af50ab

Browse files
committed
test: Update test expectations
Signed-off-by: Tomas Kislan <[email protected]>
1 parent c04a3ff commit 0af50ab

File tree

1 file changed

+12
-8
lines changed

1 file changed

+12
-8
lines changed

src/platform/notebooks/deepnote/sqlIntegrationEnvironmentVariablesProvider.unit.test.ts

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ import {
1414
} from './integrationTypes';
1515
import { mockedVSCodeNamespaces, resetVSCodeMocks } from '../../../test/vscode-mock';
1616

17+
const EXPECTED_EMPTY_ENV_VARS = {
18+
SQL_DEEPNOTE_DATAFRAME_SQL: '{"url":"deepnote+duckdb:///:memory:","params":{},"param_style":"qmark"}'
19+
};
20+
1721
suite('SqlIntegrationEnvironmentVariablesProvider', () => {
1822
let provider: SqlIntegrationEnvironmentVariablesProvider;
1923
let integrationStorage: IntegrationStorage;
@@ -55,7 +59,7 @@ suite('SqlIntegrationEnvironmentVariablesProvider', () => {
5559
when(mockedVSCodeNamespaces.workspace.notebookDocuments).thenReturn([notebook]);
5660

5761
const envVars = await provider.getEnvironmentVariables(uri);
58-
assert.deepStrictEqual(envVars, {});
62+
assert.deepStrictEqual(envVars, EXPECTED_EMPTY_ENV_VARS);
5963
});
6064

6165
test('Returns empty object when SQL cells have no integration ID', async () => {
@@ -67,7 +71,7 @@ suite('SqlIntegrationEnvironmentVariablesProvider', () => {
6771
when(mockedVSCodeNamespaces.workspace.notebookDocuments).thenReturn([notebook]);
6872

6973
const envVars = await provider.getEnvironmentVariables(uri);
70-
assert.deepStrictEqual(envVars, {});
74+
assert.deepStrictEqual(envVars, EXPECTED_EMPTY_ENV_VARS);
7175
});
7276

7377
test('Returns environment variable for internal DuckDB integration', async () => {
@@ -188,7 +192,7 @@ suite('SqlIntegrationEnvironmentVariablesProvider', () => {
188192

189193
// Should only have one environment variable
190194
assert.property(envVars, 'SQL_MY_POSTGRES_DB');
191-
assert.strictEqual(Object.keys(envVars).length, 1);
195+
assert.strictEqual(Object.keys(envVars).length, 2);
192196
});
193197

194198
test('Handles multiple SQL cells with different integrations', async () => {
@@ -233,7 +237,7 @@ suite('SqlIntegrationEnvironmentVariablesProvider', () => {
233237
// Should have two environment variables
234238
assert.property(envVars, 'SQL_MY_POSTGRES_DB');
235239
assert.property(envVars, 'SQL_MY_BIGQUERY');
236-
assert.strictEqual(Object.keys(envVars).length, 2);
240+
assert.strictEqual(Object.keys(envVars).length, 3);
237241
});
238242

239243
test('Handles missing integration configuration gracefully', async () => {
@@ -252,7 +256,7 @@ suite('SqlIntegrationEnvironmentVariablesProvider', () => {
252256
const envVars = await provider.getEnvironmentVariables(uri);
253257

254258
// Should return empty object when integration config is missing
255-
assert.deepStrictEqual(envVars, {});
259+
assert.deepStrictEqual(envVars, EXPECTED_EMPTY_ENV_VARS);
256260
});
257261

258262
test('Properly encodes special characters in PostgreSQL credentials', async () => {
@@ -623,7 +627,7 @@ suite('SqlIntegrationEnvironmentVariablesProvider', () => {
623627

624628
// Should return empty object when unsupported auth method is encountered
625629
const envVars = await provider.getEnvironmentVariables(uri);
626-
assert.deepStrictEqual(envVars, {});
630+
assert.deepStrictEqual(envVars, EXPECTED_EMPTY_ENV_VARS);
627631
});
628632

629633
test('Skips unsupported Snowflake auth method (AZURE_AD)', async () => {
@@ -647,7 +651,7 @@ suite('SqlIntegrationEnvironmentVariablesProvider', () => {
647651
when(integrationStorage.getIntegrationConfig(integrationId)).thenResolve(config);
648652

649653
const envVars = await provider.getEnvironmentVariables(uri);
650-
assert.deepStrictEqual(envVars, {});
654+
assert.deepStrictEqual(envVars, EXPECTED_EMPTY_ENV_VARS);
651655
});
652656

653657
test('Skips unsupported Snowflake auth method (KEY_PAIR)', async () => {
@@ -671,7 +675,7 @@ suite('SqlIntegrationEnvironmentVariablesProvider', () => {
671675
when(integrationStorage.getIntegrationConfig(integrationId)).thenResolve(config);
672676

673677
const envVars = await provider.getEnvironmentVariables(uri);
674-
assert.deepStrictEqual(envVars, {});
678+
assert.deepStrictEqual(envVars, EXPECTED_EMPTY_ENV_VARS);
675679
});
676680
});
677681
});

0 commit comments

Comments
 (0)