refactor: deduplicate EXCLUDED_INTEGRATION_ID constant and simplify to string

Author: jankuca

src/notebooks/deepnote/integrations/integrationDetector.ts

@@ -2,17 +2,14 @@ import { inject, injectable } from 'inversify';
 
 import { logger } from '../../../platform/logging';
 import { IDeepnoteNotebookManager } from '../../types';
-import { IntegrationStatus, IntegrationWithStatus } from './integrationTypes';
+import { DATAFRAME_SQL_INTEGRATION_ID, IntegrationStatus, IntegrationWithStatus } from './integrationTypes';
 import { IIntegrationDetector, IIntegrationStorage } from './types';
 
 /**
  * Service for detecting integrations used in Deepnote notebooks
  */
 @injectable()
 export class IntegrationDetector implements IIntegrationDetector {
-    // Special integration IDs that should be excluded from management
-    private readonly EXCLUDED_INTEGRATION_IDS = new Set(['deepnote-dataframe-sql']);
-
     constructor(
         @inject(IIntegrationStorage) private readonly integrationStorage: IIntegrationStorage,
         @inject(IDeepnoteNotebookManager) private readonly notebookManager: IDeepnoteNotebookManager
@@ -48,7 +45,7 @@ export class IntegrationDetector implements IIntegrationDetector {
                     const integrationId = block.metadata.sql_integration_id;
 
                     // Skip excluded integrations (e.g., internal DuckDB integration)
-                    if (this.EXCLUDED_INTEGRATION_IDS.has(integrationId)) {
+                    if (integrationId === DATAFRAME_SQL_INTEGRATION_ID) {
                         logger.trace(
                             `IntegrationDetector: Skipping excluded integration: ${integrationId} in block ${block.id}`
                         );

src/notebooks/deepnote/integrations/integrationManager.ts

@@ -6,16 +6,13 @@ import { Commands } from '../../../platform/common/constants';
 import { logger } from '../../../platform/logging';
 import { IntegrationWebviewProvider } from './integrationWebview';
 import { IIntegrationDetector, IIntegrationStorage } from './types';
-import { IntegrationStatus, IntegrationWithStatus } from './integrationTypes';
+import { DATAFRAME_SQL_INTEGRATION_ID, IntegrationStatus, IntegrationWithStatus } from './integrationTypes';
 
 /**
  * Manages integration UI and commands for Deepnote notebooks
  */
 @injectable()
 export class IntegrationManager {
-    // Special integration IDs that should be excluded from management
-    private readonly EXCLUDED_INTEGRATION_IDS = new Set(['deepnote-dataframe-sql']);
-
     private hasIntegrationsContext = 'deepnote.hasIntegrations';
 
     private hasUnconfiguredIntegrationsContext = 'deepnote.hasUnconfiguredIntegrations';
@@ -134,7 +131,7 @@ export class IntegrationManager {
                 const integrationId = deepnoteMetadata.sql_integration_id;
 
                 // Skip excluded integrations (e.g., internal DuckDB integration)
-                if (this.EXCLUDED_INTEGRATION_IDS.has(integrationId)) {
+                if (integrationId === DATAFRAME_SQL_INTEGRATION_ID) {
                     logger.trace(`IntegrationManager: Skipping excluded integration: ${integrationId}`);
                     continue;
                 }

src/notebooks/deepnote/integrations/integrationTypes.ts

@@ -1,3 +1,9 @@
+/**
+ * Special integration ID that should be excluded from management.
+ * This is the internal DuckDB integration that doesn't require configuration.
+ */
+export const DATAFRAME_SQL_INTEGRATION_ID = 'deepnote-dataframe-sql';
+
 /**
  * Supported integration types
  */