add dispose logic for integration storage

Author: jankuca

src/notebooks/deepnote/integrations/integrationStorage.ts

@@ -2,6 +2,7 @@ import { inject, injectable } from 'inversify';
 import { EventEmitter } from 'vscode';
 
 import { IEncryptedStorage } from '../../../platform/common/application/types';
+import { IAsyncDisposableRegistry } from '../../../platform/common/types';
 import { logger } from '../../../platform/logging';
 import { IntegrationConfig, IntegrationType } from './integrationTypes';
 
@@ -22,7 +23,13 @@ export class IntegrationStorage {
 
     public readonly onDidChangeIntegrations = this._onDidChangeIntegrations.event;
 
-    constructor(@inject(IEncryptedStorage) private readonly encryptedStorage: IEncryptedStorage) {}
+    constructor(
+        @inject(IEncryptedStorage) private readonly encryptedStorage: IEncryptedStorage,
+        @inject(IAsyncDisposableRegistry) asyncRegistry: IAsyncDisposableRegistry
+    ) {
+        // Register for disposal when the extension deactivates
+        asyncRegistry.push(this);
+    }
 
     /**
      * Get all stored integration configurations
@@ -168,4 +175,11 @@ export class IntegrationStorage {
         const indexJson = JSON.stringify(integrationIds);
         await this.encryptedStorage.store(INTEGRATION_SERVICE_NAME, 'index', indexJson);
     }
+
+    /**
+     * Dispose of resources to prevent memory leaks
+     */
+    public dispose(): void {
+        this._onDidChangeIntegrations.dispose();
+    }
 }

src/notebooks/deepnote/integrations/types.ts

@@ -1,8 +1,9 @@
 import { Event } from 'vscode';
+import { IDisposable } from '../../../platform/common/types';
 import { IntegrationConfig, IntegrationWithStatus } from './integrationTypes';
 
 export const IIntegrationStorage = Symbol('IIntegrationStorage');
-export interface IIntegrationStorage {
+export interface IIntegrationStorage extends IDisposable {
     /**
      * Event fired when integrations change
      */