Skip to content

Commit 18b3faf

Browse files
committed
polish localization of select input settings
1 parent 84f4404 commit 18b3faf

File tree

4 files changed

+4
-1
lines changed

4 files changed

+4
-1
lines changed

src/messageTypes.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,7 @@ export type LocalizedMessages = {
216216
fromVariable: string;
217217
fromVariableDescription: string;
218218
variablePlaceholder: string;
219+
removeOptionAriaLabel: string;
219220
saveButton: string;
220221
cancelButton: string;
221222
};

src/notebooks/deepnote/selectInputSettingsWebview.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ export class SelectInputSettingsWebviewProvider {
132132
fromVariable: localize.SelectInputSettings.fromVariable,
133133
fromVariableDescription: localize.SelectInputSettings.fromVariableDescription,
134134
variablePlaceholder: localize.SelectInputSettings.variablePlaceholder,
135+
removeOptionAriaLabel: localize.SelectInputSettings.removeOptionAriaLabel,
135136
saveButton: localize.SelectInputSettings.saveButton,
136137
cancelButton: localize.SelectInputSettings.cancelButton
137138
};

src/platform/common/utils/localize.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -871,6 +871,7 @@ export namespace SelectInputSettings {
871871
export const fromVariable = l10n.t('From variable');
872872
export const fromVariableDescription = l10n.t('A list or Series that contains only strings, numbers or booleans.');
873873
export const variablePlaceholder = l10n.t('Variable name...');
874+
export const removeOptionAriaLabel = l10n.t('Remove option');
874875
export const saveButton = l10n.t('Save');
875876
export const cancelButton = l10n.t('Cancel');
876877
}

src/webviews/webview-side/selectInputSettings/SelectInputSettingsPanel.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ export const SelectInputSettingsPanel: React.FC<ISelectInputSettingsPanelProps>
171171
<button
172172
type="button"
173173
onClick={() => handleRemoveOption(index)}
174-
aria-label="Remove option"
174+
aria-label={getLocString('removeOptionAriaLabel', 'Remove option')}
175175
>
176176
×
177177
</button>

0 commit comments

Comments
 (0)