Skip to content

Commit 5490f3d

Browse files
Merge branch 'main' into filipzitny/mar-253-contributing-guide-for-deepnotevscode-deepnote
2 parents 0e62508 + 87e8346 commit 5490f3d

File tree

146 files changed

+11296
-1525
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

146 files changed

+11296
-1525
lines changed

.devcontainer/dev-with-python/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333

3434
"mounts": ["source=${localWorkspaceFolder},target=/workspaces/local,type=bind,consistency=cached"],
3535
// Use 'postCreateCommand' to run commands after the container is created.
36-
// "postCreateCommand": "npm ci",
36+
// "postCreateCommand": "npm install",
3737
// Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
3838
"remoteUser": "vscode"
3939
}

.devcontainer/dev/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
},
2020
"mounts": ["source=${localWorkspaceFolder},target=/workspaces/local,type=bind,consistency=cached"]
2121
// Use 'postCreateCommand' to run commands after the container is created.
22-
// "postCreateCommand": "npm ci",
22+
// "postCreateCommand": "npm install",
2323
// Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
2424
// , "remoteUser": "vscode"
2525
}

.eslintrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ module.exports = {
7474
'import/no-unresolved': [
7575
'error',
7676
{
77-
ignore: ['monaco-editor', 'vscode']
77+
ignore: ['monaco-editor', 'vscode', 'react-error-boundary']
7878
}
7979
],
8080
'import/prefer-default-export': 'off',

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
# Default owners for everything in the repository
2-
* @saltenasl @jamesbhobbs @Artmann
2+
* @deepnote/oss-maintainers

.github/actions/create-venv-for-tests/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ runs:
1616
using: 'composite'
1717
steps:
1818
- name: Install uv
19-
uses: astral-sh/setup-uv@d0cc045d04ccac9d8b7881df0226f9e82c39688e # v6
19+
uses: astral-sh/setup-uv@2ddd2b9cb38ad8efd50337e8ab201519a34c9f24 # v7
2020

2121
# Used by tests for installation of ipykernel.
2222
# Create a venv & register it as a kernel.

.github/commands.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@
261261
"action": "close",
262262
"reason": "not_planned",
263263
"addLabel": "*caused-by-extension",
264-
"comment": "It looks like this is caused by the Jupyter extension. Please file the issue to the [Jupyter extension repository](https://github.com/microsoft/vscode-jupyter). Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our [issue reporting guidelines](https://aka.ms/vscodeissuereporting) for more information.\n\nHappy Coding!"
264+
"comment": "It looks like this is caused by the Jupyter extension. Please file the issue to the [Jupyter extension repository](https://github.com/deepnote/vscode-deepnote). Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our [issue reporting guidelines](https://aka.ms/vscodeissuereporting) for more information.\n\nHappy Coding!"
265265
},
266266
{
267267
"type": "comment",

.github/endgame_plan.md

Lines changed: 0 additions & 115 deletions
This file was deleted.

.github/workflows/ci.yml

Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@ on:
77
branches: [main]
88
workflow_dispatch:
99

10-
env:
11-
NODE_VERSION: 22.x
12-
1310
permissions:
1411
actions: read
1512
contents: read
@@ -29,10 +26,10 @@ jobs:
2926
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
3027

3128
- name: Setup Node.js
32-
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
29+
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6
3330
with:
3431
cache: 'npm'
35-
node-version: ${{ env.NODE_VERSION }}
32+
node-version-file: '.nvmrc'
3633
registry-url: 'https://npm.pkg.github.com'
3734
scope: '@deepnote'
3835

@@ -56,10 +53,10 @@ jobs:
5653
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
5754

5855
- name: Setup Node.js
59-
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
56+
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6
6057
with:
6158
cache: 'npm'
62-
node-version: ${{ env.NODE_VERSION }}
59+
node-version-file: '.nvmrc'
6360
registry-url: 'https://npm.pkg.github.com'
6461
scope: '@deepnote'
6562

@@ -83,7 +80,7 @@ jobs:
8380
fetch-depth: 0
8481

8582
- name: Install qlty
86-
uses: qltysh/qlty-action/install@6bbb1add7432c45a3fd35a824ea69dc5bef27967
83+
uses: qltysh/qlty-action/install@92420f3093ba65970fed22ce5f162ecb8a5c1700
8784

8885
- name: Run qlty check
8986
run: qlty check
@@ -104,10 +101,10 @@ jobs:
104101
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
105102

106103
- name: Setup Node.js
107-
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
104+
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6
108105
with:
109106
cache: 'npm'
110-
node-version: ${{ env.NODE_VERSION }}
107+
node-version-file: '.nvmrc'
111108
registry-url: 'https://npm.pkg.github.com'
112109
scope: '@deepnote'
113110

@@ -154,10 +151,10 @@ jobs:
154151
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
155152

156153
- name: Setup Node.js
157-
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
154+
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6
158155
with:
159156
cache: 'npm'
160-
node-version: ${{ env.NODE_VERSION }}
157+
node-version-file: '.nvmrc'
161158
registry-url: 'https://npm.pkg.github.com'
162159
scope: '@deepnote'
163160

@@ -178,10 +175,10 @@ jobs:
178175
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
179176

180177
- name: Setup Node.js
181-
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
178+
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6
182179
with:
183180
cache: 'npm'
184-
node-version: ${{ env.NODE_VERSION }}
181+
node-version-file: '.nvmrc'
185182
registry-url: 'https://npm.pkg.github.com'
186183
scope: '@deepnote'
187184

@@ -202,10 +199,10 @@ jobs:
202199
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
203200

204201
- name: Setup Node.js
205-
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
202+
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6
206203
with:
207204
cache: 'npm'
208-
node-version: ${{ env.NODE_VERSION }}
205+
node-version-file: '.nvmrc'
209206
registry-url: 'https://npm.pkg.github.com'
210207
scope: '@deepnote'
211208

@@ -226,10 +223,10 @@ jobs:
226223
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
227224

228225
- name: Setup Node.js
229-
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
226+
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6
230227
with:
231228
cache: 'npm'
232-
node-version: ${{ env.NODE_VERSION }}
229+
node-version-file: '.nvmrc'
233230
registry-url: 'https://npm.pkg.github.com'
234231
scope: '@deepnote'
235232

.github/workflows/copilot-setup-steps.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ on:
1212
- .github/workflows/copilot-setup-steps.yml
1313

1414
env:
15-
NODE_VERSION: 22.15.1
1615
NPM_VERSION: 10.9.2
1716
PYTHON_VERSION: 3.12
1817
DENO_VERSION: '~1.37'
@@ -40,9 +39,9 @@ jobs:
4039
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
4140

4241
- name: Use Node ${{env.NODE_VERSION}}
43-
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
42+
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6
4443
with:
45-
node-version: ${{env.NODE_VERSION}}
44+
node-version-file: '.nvmrc'
4645
registry-url: 'https://npm.pkg.github.com'
4746
scope: '@deepnote'
4847

.github/workflows/deps.yml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@ on:
66
- cron: '0 9 * * 1'
77
workflow_dispatch:
88

9-
env:
10-
NODE_VERSION: 22.x
11-
129
permissions:
1310
actions: read
1411
contents: read
@@ -27,10 +24,10 @@ jobs:
2724
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
2825

2926
- name: Setup Node.js
30-
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
27+
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6
3128
with:
3229
cache: 'npm'
33-
node-version: ${{ env.NODE_VERSION }}
30+
node-version-file: '.nvmrc'
3431
registry-url: 'https://npm.pkg.github.com'
3532
scope: '@deepnote'
3633

@@ -60,9 +57,9 @@ jobs:
6057
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
6158

6259
- name: Setup Node.js
63-
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
60+
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6
6461
with:
65-
node-version: ${{ env.NODE_VERSION }}
62+
node-version-file: '.nvmrc'
6663
cache: 'npm'
6764

6865
- name: Install dependencies

0 commit comments

Comments
 (0)