Skip to content

Commit 5cb5722

Browse files
fix: add coverage instrumentation env var and fail_ci_if_error to test results upload
- Add VSC_JUPYTER_INSTRUMENT_CODE_FOR_COVERAGE env var to test step to enable coverage generation - Add fail_ci_if_error: false to test results upload for consistency with coverage upload Addresses CodeRabbit automated review feedback on PR #35
1 parent 36a4ab4 commit 5cb5722

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,8 @@ jobs:
9191

9292
- name: Run tests
9393
run: npm test
94+
env:
95+
VSC_JUPYTER_INSTRUMENT_CODE_FOR_COVERAGE: true
9496

9597
- name: Upload coverage to Codecov
9698
uses: codecov/codecov-action@v5
@@ -105,6 +107,7 @@ jobs:
105107
with:
106108
token: ${{ secrets.CODECOV_TOKEN }}
107109
files: test-report.xml
110+
fail_ci_if_error: false
108111

109112
- name: Check dependencies
110113
run: npm run checkDependencies

0 commit comments

Comments
 (0)