refactor: Update DeepnoteEnvironmentTreeItem to use consistent IDs for info items

- Modified createInfoItem method to accept an ID parameter for better identification of info items.
- Updated instances of createInfoItem across the DeepnoteEnvironmentTreeDataProvider to use the new ID format.
- Enhanced unit tests to reflect changes in info item creation and ensure proper functionality.

Signed-off-by: Tomas Kislan <[email protected]>

Author: tkislan

src/kernels/deepnote/environments/deepnoteEnvironmentTreeDataProvider.node.ts

@@ -85,45 +85,61 @@ export class DeepnoteEnvironmentTreeDataProvider implements TreeDataProvider<Dee
         if (statusInfo?.status === EnvironmentStatus.Running && config.serverInfo) {
             items.push(
                 DeepnoteEnvironmentTreeItem.createInfoItem(
+                    'ports',
                     `Ports: jupyter=${config.serverInfo.jupyterPort}, lsp=${config.serverInfo.lspPort}`,
                     'port'
                 )
             );
-            items.push(DeepnoteEnvironmentTreeItem.createInfoItem(`URL: ${config.serverInfo.url}`, 'globe'));
+            items.push(DeepnoteEnvironmentTreeItem.createInfoItem('url', `URL: ${config.serverInfo.url}`, 'globe'));
         }
 
         // Python interpreter
         items.push(
             DeepnoteEnvironmentTreeItem.createInfoItem(
+                'python',
                 `Python: ${config.pythonInterpreter.uri.fsPath}`,
                 'symbol-namespace'
             )
         );
 
         // Venv path
-        items.push(DeepnoteEnvironmentTreeItem.createInfoItem(`Venv: ${config.venvPath.fsPath}`, 'folder'));
+        items.push(DeepnoteEnvironmentTreeItem.createInfoItem('venv', `Venv: ${config.venvPath.fsPath}`, 'folder'));
 
         // Packages
         if (config.packages && config.packages.length > 0) {
             items.push(
-                DeepnoteEnvironmentTreeItem.createInfoItem(`Packages: ${config.packages.join(', ')}`, 'package')
+                DeepnoteEnvironmentTreeItem.createInfoItem(
+                    'packages',
+                    `Packages: ${config.packages.join(', ')}`,
+                    'package'
+                )
             );
         } else {
-            items.push(DeepnoteEnvironmentTreeItem.createInfoItem('Packages: (none)', 'package'));
+            items.push(DeepnoteEnvironmentTreeItem.createInfoItem('packages', 'Packages: (none)', 'package'));
         }
 
         // Toolkit version
         if (config.toolkitVersion) {
-            items.push(DeepnoteEnvironmentTreeItem.createInfoItem(`Toolkit: ${config.toolkitVersion}`, 'versions'));
+            items.push(
+                DeepnoteEnvironmentTreeItem.createInfoItem('toolkit', `Toolkit: ${config.toolkitVersion}`, 'versions')
+            );
         }
 
         // Timestamps
         items.push(
-            DeepnoteEnvironmentTreeItem.createInfoItem(`Created: ${config.createdAt.toLocaleString()}`, 'history')
+            DeepnoteEnvironmentTreeItem.createInfoItem(
+                'created',
+                `Created: ${config.createdAt.toLocaleString()}`,
+                'history'
+            )
         );
 
         items.push(
-            DeepnoteEnvironmentTreeItem.createInfoItem(`Last used: ${config.lastUsedAt.toLocaleString()}`, 'clock')
+            DeepnoteEnvironmentTreeItem.createInfoItem(
+                'lastUsed',
+                `Last used: ${config.lastUsedAt.toLocaleString()}`,
+                'clock'
+            )
         );
 
         return items;

src/kernels/deepnote/environments/deepnoteEnvironmentTreeItem.node.ts

@@ -12,6 +12,16 @@ export enum EnvironmentTreeItemType {
     CreateAction = 'create'
 }
 
+export type DeepnoteEnvironmentTreeInfoItemId =
+    | 'ports'
+    | 'url'
+    | 'python'
+    | 'venv'
+    | 'packages'
+    | 'toolkit'
+    | 'created'
+    | 'lastUsed';
+
 /**
  * Tree item for displaying environments and related info
  */
@@ -37,8 +47,13 @@ export class DeepnoteEnvironmentTreeItem extends TreeItem {
     /**
      * Create an info item to display under an environment
      */
-    public static createInfoItem(label: string, icon?: string): DeepnoteEnvironmentTreeItem {
+    public static createInfoItem(
+        id: DeepnoteEnvironmentTreeInfoItemId,
+        label: string,
+        icon?: string
+    ): DeepnoteEnvironmentTreeItem {
         const item = new DeepnoteEnvironmentTreeItem(EnvironmentTreeItemType.InfoItem, undefined, undefined, label);
+        item.id = `info-${id}`;
 
         if (icon) {
             item.iconPath = new ThemeIcon(icon);
@@ -54,6 +69,7 @@ export class DeepnoteEnvironmentTreeItem extends TreeItem {
 
         const statusVisual = getDeepnoteEnvironmentStatusVisual(this.status ?? EnvironmentStatus.Stopped);
 
+        this.id = this.environment.id;
         this.label = `${this.environment.name} [${statusVisual.text}]`;
         this.iconPath = new ThemeIcon(statusVisual.icon, new ThemeColor(statusVisual.themeColorId));
         this.contextValue = statusVisual.contextValue;
@@ -76,6 +92,7 @@ export class DeepnoteEnvironmentTreeItem extends TreeItem {
     }
 
     private setupCreateAction(): void {
+        this.id = 'create';
         this.label = l10n.t('Create New Environment');
         this.iconPath = new ThemeIcon('add');
         this.contextValue = 'deepnoteEnvironment.create';

src/kernels/deepnote/environments/deepnoteEnvironmentTreeItem.unit.test.ts

@@ -149,15 +149,15 @@ suite('DeepnoteEnvironmentTreeItem', () => {
         });
 
         test('should create info item with icon', () => {
-            const item = DeepnoteEnvironmentTreeItem.createInfoItem('Port: 8888', 'circle-filled');
+            const item = DeepnoteEnvironmentTreeItem.createInfoItem('ports', 'Port: 8888', 'circle-filled');
 
             assert.strictEqual(item.label, 'Port: 8888');
             assert.instanceOf(item.iconPath, ThemeIcon);
             assert.strictEqual((item.iconPath as ThemeIcon).id, 'circle-filled');
         });
 
         test('should create info item without icon', () => {
-            const item = DeepnoteEnvironmentTreeItem.createInfoItem('No icon');
+            const item = DeepnoteEnvironmentTreeItem.createInfoItem('ports', 'No icon');
 
             assert.strictEqual(item.label, 'No icon');
             assert.isUndefined(item.iconPath);
@@ -201,6 +201,22 @@ suite('DeepnoteEnvironmentTreeItem', () => {
             assert.include(item.description as string, 'just now');
         });
 
+        test('should handle negative time (few seconds in the past)', () => {
+            const fewSecondsAgo = new Date(Date.now() - 5 * 1000);
+            const config: DeepnoteEnvironment = {
+                ...testEnvironment,
+                lastUsedAt: fewSecondsAgo
+            };
+
+            const item = new DeepnoteEnvironmentTreeItem(
+                EnvironmentTreeItemType.Environment,
+                config,
+                EnvironmentStatus.Stopped
+            );
+
+            assert.include(item.description as string, 'just now');
+        });
+
         test('should show minutes ago', () => {
             const fiveMinutesAgo = new Date(Date.now() - 5 * 60 * 1000);
             const config: DeepnoteEnvironment = {