Skip to content

Commit 75ce3a2

Browse files
committed
Fix tests
1 parent 64761dd commit 75ce3a2

File tree

2 files changed

+200
-243
lines changed

2 files changed

+200
-243
lines changed

src/notebooks/deepnote/converters/visualizationBlockConverter.ts

Lines changed: 7 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -54,24 +54,14 @@ export class VisualizationBlockConverter implements BlockConverter {
5454
try {
5555
const config = JSON.parse(cell.value || '{}');
5656

57-
if (!block.metadata) {
58-
block.metadata = {};
59-
}
60-
61-
if (config.variable) {
62-
block.metadata.deepnote_variable_name = config.variable;
63-
}
64-
65-
if (config.spec) {
66-
block.metadata.deepnote_visualization_spec = config.spec;
67-
}
68-
69-
if (config.filters) {
70-
if (!block.metadata.deepnote_chart_filter) {
71-
block.metadata.deepnote_chart_filter = {};
57+
block.metadata = {
58+
...block.metadata,
59+
deepnote_variable_name: config.variable || '',
60+
deepnote_visualization_spec: config.spec || {},
61+
deepnote_chart_filter: {
62+
advancedFilters: config.filters || []
7263
}
73-
block.metadata.deepnote_chart_filter.advancedFilters = config.filters;
74-
}
64+
};
7565
} catch (error) {
7666
// If JSON parsing fails, leave metadata unchanged
7767
console.warn('Failed to parse visualization JSON:', error);

0 commit comments

Comments
 (0)