feedback

Author: Artmann

.github/ISSUE_TEMPLATE/config.yml

@@ -2,7 +2,7 @@ blank_issues_enabled: false
 contact_links:
   - name: 'Help and Support'
     url: https://github.com/deepnote/vscode-extension/discussions
-    about: "Need help getting something to work, but you're not sure it's worth of submitting an issue? Ask here."
+    about: "Need help getting something to work, but you're not sure it's worth submitting an issue? Ask here."
   - name: 'Chat on Discord'
     url: https://aka.ms/python-discord
     about: 'You can ask for help or chat in the `#jupyter` channel of our microsoft-python Discord server'

.github/workflows/ci.yml

@@ -15,13 +15,17 @@ permissions:
   contents: read
   actions: read
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   lint:
     name: Lint & Format
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v5
+        uses: actions/checkout@v4
 
       - name: Setup Node.js
         uses: actions/setup-node@v4
@@ -46,7 +50,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v5
+        uses: actions/checkout@v4
 
       - name: Setup Node.js
         uses: actions/setup-node@v4

.github/workflows/deps.yml

@@ -31,7 +31,14 @@ jobs:
         run: npm ci --prefer-offline --no-audit
 
       - name: Run security audit
-        run: npm audit --audit-level=moderate
+        run: npm audit --json > audit-report.json || true
+
+      - name: Upload audit report
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: npm-audit-report
+          path: audit-report.json
 
       - name: Check for outdated packages
         run: npm outdated || true

src/notebooks/deepnote/deepnoteActivationService.ts

@@ -3,7 +3,7 @@ import { workspace, commands, window, WorkspaceEdit, NotebookEdit, NotebookRange
 import { IExtensionSyncActivationService } from '../../platform/activation/types';
 import { IExtensionContext } from '../../platform/common/types';
 import { DeepnoteNotebookSerializer } from './deepnoteSerializer';
-import { DeepnoteProject } from './deepnoteTypes';
+import type { DeepnoteProject } from './deepnoteTypes';
 import { DeepnoteNotebookSelector } from './deepnoteNotebookSelector';
 import { Commands } from '../../platform/common/constants';
 

src/notebooks/deepnote/deepnoteDataConverter.ts

@@ -25,7 +25,7 @@ export class DeepnoteDataConverter {
                 deepnoteBlockType: block.type,
                 deepnoteSortingKey: block.sortingKey,
                 deepnoteMetadata: block.metadata,
-                ...(block.executionCount && { executionCount: block.executionCount }),
+                ...(typeof block.executionCount === 'number' && { executionCount: block.executionCount }),
                 ...(block.outputReference && { deepnoteOutputReference: block.outputReference })
             },
             outputs: this.convertDeepnoteOutputsToVSCodeOutputs(block.outputs || [])

src/notebooks/deepnote/deepnoteSerializer.ts

@@ -13,35 +13,35 @@ export class DeepnoteNotebookSerializer implements NotebookSerializer {
     private static converter = new DeepnoteDataConverter();
 
     static setSelectedNotebookForUri(uri: string, notebookId: string) {
-        this.manager.setSelectedNotebookForUri(uri, notebookId);
+        DeepnoteNotebookSerializer.manager.setSelectedNotebookForUri(uri, notebookId);
     }
 
     static getSelectedNotebookForUri(uri: string): string | undefined {
-        return this.manager.getSelectedNotebookForUri(uri);
+        return DeepnoteNotebookSerializer.manager.getSelectedNotebookForUri(uri);
     }
 
     static shouldSkipPrompt(uri: string): boolean {
-        return this.manager.shouldSkipPrompt(uri);
+        return DeepnoteNotebookSerializer.manager.shouldSkipPrompt(uri);
     }
 
     static storeOriginalProject(projectId: string, project: DeepnoteProject, notebookId: string) {
-        this.manager.storeOriginalProject(projectId, project, notebookId);
+        DeepnoteNotebookSerializer.manager.storeOriginalProject(projectId, project, notebookId);
     }
 
     static getOriginalProject(projectId: string): DeepnoteProject | undefined {
-        return this.manager.getOriginalProject(projectId);
+        return DeepnoteNotebookSerializer.manager.getOriginalProject(projectId);
     }
 
     static getCurrentNotebookId(projectId: string): string | undefined {
-        return this.manager.getCurrentNotebookId(projectId);
+        return DeepnoteNotebookSerializer.manager.getCurrentNotebookId(projectId);
     }
 
     static getManager(): DeepnoteNotebookManager {
-        return this.manager;
+        return DeepnoteNotebookSerializer.manager;
     }
 
     static getConverter(): DeepnoteDataConverter {
-        return this.converter;
+        return DeepnoteNotebookSerializer.converter;
     }
 
     async deserializeNotebook(content: Uint8Array, _token: CancellationToken): Promise<NotebookData> {
@@ -53,7 +53,6 @@ export class DeepnoteNotebookSerializer implements NotebookSerializer {
                 throw new Error('Invalid Deepnote file: no notebooks found');
             }
 
-            // Select the notebook to open
             const selectedNotebook = await this.selectNotebookForOpen(
                 deepnoteProject.project.id,
                 deepnoteProject.project.notebooks
@@ -84,6 +83,7 @@ export class DeepnoteNotebookSerializer implements NotebookSerializer {
             };
         } catch (error) {
             console.error('Error deserializing Deepnote notebook:', error);
+
             throw new Error(
                 `Failed to parse Deepnote file: ${error instanceof Error ? error.message : 'Unknown error'}`
             );