Skip to content

Commit 844ee6d

Browse files
committed
test: add assertion of sql status bar item commands and alignments
1 parent 6f8e183 commit 844ee6d

File tree

1 file changed

+22
-0
lines changed

1 file changed

+22
-0
lines changed

src/notebooks/deepnote/sqlCellStatusBarProvider.unit.test.ts

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,17 @@ suite('SqlCellStatusBarProvider', () => {
5858
assert.strictEqual(integrationItem.alignment, 1);
5959
assert.isDefined(integrationItem.command);
6060
assert.strictEqual(integrationItem.command.command, 'deepnote.switchSqlIntegration');
61+
assert.deepStrictEqual(integrationItem.command.arguments, [cell]);
62+
assert.strictEqual(integrationItem.priority, 100);
6163

6264
// Check variable status bar item
6365
const variableItem = items[1];
6466
assert.strictEqual(variableItem.text, 'Variable: df');
6567
assert.strictEqual(variableItem.alignment, 1);
6668
assert.isDefined(variableItem.command);
6769
assert.strictEqual(variableItem.command.command, 'deepnote.updateSqlVariableName');
70+
assert.deepStrictEqual(variableItem.command.arguments, [cell]);
71+
assert.strictEqual(variableItem.priority, 90);
6872
});
6973

7074
test('returns status bar items for SQL cells with dataframe integration ID', async () => {
@@ -89,13 +93,17 @@ suite('SqlCellStatusBarProvider', () => {
8993
);
9094
assert.isDefined(integrationItem.command);
9195
assert.strictEqual(integrationItem.command.command, 'deepnote.switchSqlIntegration');
96+
assert.deepStrictEqual(integrationItem.command.arguments, [cell]);
97+
assert.strictEqual(integrationItem.priority, 100);
9298

9399
// Check variable status bar item
94100
const variableItem = items[1];
95101
assert.strictEqual(variableItem.text, 'Variable: df');
96102
assert.strictEqual(variableItem.alignment, 1);
97103
assert.isDefined(variableItem.command);
98104
assert.strictEqual(variableItem.command.command, 'deepnote.updateSqlVariableName');
105+
assert.deepStrictEqual(variableItem.command.arguments, [cell]);
106+
assert.strictEqual(variableItem.priority, 90);
99107
});
100108

101109
test('returns status bar items for SQL cell with integration ID', async () => {
@@ -135,13 +143,16 @@ suite('SqlCellStatusBarProvider', () => {
135143
assert.isDefined(integrationItem.command);
136144
assert.strictEqual(integrationItem.command.command, 'deepnote.switchSqlIntegration');
137145
assert.deepStrictEqual(integrationItem.command.arguments, [cell]);
146+
assert.strictEqual(integrationItem.priority, 100);
138147

139148
// Check variable status bar item
140149
const variableItem = items[1];
141150
assert.strictEqual(variableItem.text, 'Variable: df');
142151
assert.strictEqual(variableItem.alignment, 1);
143152
assert.isDefined(variableItem.command);
144153
assert.strictEqual(variableItem.command.command, 'deepnote.updateSqlVariableName');
154+
assert.deepStrictEqual(variableItem.command.arguments, [cell]);
155+
assert.strictEqual(variableItem.priority, 90);
145156
});
146157

147158
test('shows "Unknown integration (configure)" when config not found', async () => {
@@ -165,7 +176,13 @@ suite('SqlCellStatusBarProvider', () => {
165176
const items = result as any[];
166177
assert.strictEqual(items.length, 2);
167178
assert.strictEqual(items[0].text, '$(database) Unknown integration (configure)');
179+
assert.strictEqual(items[0].alignment, 1);
180+
assert.strictEqual(items[0].command.command, 'deepnote.switchSqlIntegration');
181+
assert.deepStrictEqual(items[0].command.arguments, [cell]);
168182
assert.strictEqual(items[1].text, 'Variable: df');
183+
assert.strictEqual(items[1].alignment, 1);
184+
assert.strictEqual(items[1].command.command, 'deepnote.updateSqlVariableName');
185+
assert.strictEqual(items[1].priority, 90);
169186
});
170187

171188
test('returns only variable item when notebook has no project ID', async () => {
@@ -185,6 +202,9 @@ suite('SqlCellStatusBarProvider', () => {
185202
const variableItem = items[0];
186203
assert.strictEqual(variableItem.text, 'Variable: df');
187204
assert.strictEqual(variableItem.alignment, 1);
205+
assert.strictEqual(variableItem.command.command, 'deepnote.updateSqlVariableName');
206+
assert.deepStrictEqual(variableItem.command.arguments, [cell]);
207+
assert.strictEqual(variableItem.priority, 90);
188208
});
189209

190210
test('shows custom variable name when set in metadata', async () => {
@@ -221,6 +241,8 @@ suite('SqlCellStatusBarProvider', () => {
221241
// Check variable status bar item shows custom name
222242
const variableItem = items[1];
223243
assert.strictEqual(variableItem.text, 'Variable: my_results');
244+
assert.strictEqual(variableItem.alignment, 1);
245+
assert.strictEqual(variableItem.command.command, 'deepnote.updateSqlVariableName');
224246
});
225247

226248
suite('activate', () => {

0 commit comments

Comments
 (0)