Skip to content

Commit 86e32ae

Browse files
committed
last fixes
1 parent 3ef5f53 commit 86e32ae

File tree

4 files changed

+13
-12
lines changed

4 files changed

+13
-12
lines changed

CONTRIBUTING.md

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,16 @@
1919
4. Windows, macOS, or Linux
2020
5. [Visual Studio Code](https://code.visualstudio.com/)
2121
6. The following VS Code extensions:
22-
- [ESLint](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint)
23-
- [Prettier](https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode)
24-
- [EditorConfig for VS Code](https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig)
25-
- [Python Extension for VS Code](https://marketplace.visualstudio.com/items?itemName=ms-python.python)
22+
- [ESLint](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint)
23+
- [Prettier](https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode)
24+
- [EditorConfig for VS Code](https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig)
25+
- [Python Extension for VS Code](https://marketplace.visualstudio.com/items?itemName=ms-python.python)
2626

2727
### Setup
2828

2929
```shell
3030
git clone https://github.com/deepnote/vscode-deepnote
31-
cd vscode-jupyter
31+
cd vscode-deepnote
3232

3333
```
3434

@@ -47,6 +47,7 @@ Then install all the extensions listed under "Workspace Recommendations".
4747
The `@deepnote/blocks` package is published on GitHub Packages. To install it, you'll need to authenticate with GitHub:
4848

4949
1. Create a GitHub Personal Access Token (classic) with `read:packages` scope:
50+
5051
- Go to https://github.com/settings/tokens
5152
- Click "Generate new token (classic)"
5253
- Select the `read:packages` scope
@@ -178,8 +179,8 @@ you can do this by setting environment variables. The same variables work when
178179
running from the command line or launching from within VSCode, though the
179180
mechanism used to specify them changes a little.
180181

181-
- Setting `CI_PYTHON_PATH` lets you change the version of python the tests are executed with
182-
- Setting `VSC_JUPYTER_CI_TEST_GREP` lets you filter the tests by name
182+
- Setting `CI_PYTHON_PATH` lets you change the version of python the tests are executed with
183+
- Setting `VSC_JUPYTER_CI_TEST_GREP` lets you filter the tests by name
183184

184185
_`CI_PYTHON_PATH`_
185186

@@ -239,8 +240,8 @@ VSC_JUPYTER_CI_TEST_GREP=Sorting npm run testVSCode
239240
The extension has a number of scripts in ./pythonFiles. Tests for these
240241
scripts are found in ./pythonFiles/tests. To run those tests:
241242

242-
- `python2.7 pythonFiles/tests/run_all.py`
243-
- `python3 -m pythonFiles.tests`
243+
- `python2.7 pythonFiles/tests/run_all.py`
244+
- `python3 -m pythonFiles.tests`
244245

245246
By default, functional tests are included. To exclude them:
246247

pythonFiles/aggregateTestResults.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
# %%
1515
def getRuns(createdDate):
1616
runsResponse = requests.get(
17-
"https://api.github.com/repos/deepnote/vscode-deepnote/actions/workflows/build-test.yml/runs",
17+
"https://api.github.com/repos/deepnote/vscode-deepnote/actions/workflows/ci.yml/runs"
1818
params={"created": createdDate, "branch": "main"},
1919
headers={
2020
"Accept": "application/vnd.github+json",

src/notebooks/controllers/vscodeNotebookController.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ export class VSCodeNotebookController implements Disposable, IVSCodeNotebookCont
367367
}
368368

369369
// Found on CI that sometimes VS Code calls this with old deleted cells.
370-
// See here https://github.com/deepnote/vscode-deepnote/runs/5581627878?check_suite_focus=true
370+
// See here https://github.com/microsoft/vscode-jupyter/runs/5581627878?check_suite_focus=true
371371
cells = cells.filter((cell) => {
372372
if (cell.index < 0) {
373373
logger.warn(

src/notebooks/debugger/debuggingManagerBase.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ export abstract class DebuggingManagerBase implements IDisposable, IDebuggingMan
237237
sendTelemetryEvent(DebuggingTelemetry.clickedOnSetup);
238238
void env.openExternal(
239239
Uri.parse(
240-
'https://github.com/deepnote/vscode-deepnote/wiki/Setting-Up-Run-by-Line-and-Debugging-for-Notebooks'
240+
'https://github.com/microsoft/vscode-jupyter/wiki/Setting-Up-Run-by-Line-and-Debugging-for-Notebooks'
241241
)
242242
);
243243
} else {

0 commit comments

Comments
 (0)