add encoding tests

Author: jankuca

src/platform/notebooks/deepnote/sqlIntegrationEnvironmentVariablesProvider.unit.test.ts

@@ -242,6 +242,113 @@ suite('SqlIntegrationEnvironmentVariablesProvider', () => {
         // Should return empty object when integration config is missing
         assert.deepStrictEqual(envVars, {});
     });
+
+    test('Properly encodes special characters in PostgreSQL credentials', async () => {
+        const uri = Uri.file('/test/notebook.deepnote');
+        const integrationId = 'special-chars-db';
+        const config: PostgresIntegrationConfig = {
+            id: integrationId,
+            name: 'Special Chars DB',
+            type: IntegrationType.Postgres,
+            host: 'db.example.com',
+            port: 5432,
+            database: 'my@db:name',
+            username: 'user@domain',
+            password: 'pa:ss@word!#$%',
+            ssl: false
+        };
+
+        const notebook = createMockNotebook(uri, [
+            createMockCell(0, NotebookCellKind.Code, 'sql', 'SELECT * FROM users', {
+                sql_integration_id: integrationId
+            })
+        ]);
+
+        when(mockedVSCodeNamespaces.workspace.notebookDocuments).thenReturn([notebook]);
+        when(integrationStorage.get(integrationId)).thenResolve(config);
+
+        const envVars = await provider.getEnvironmentVariables(uri);
+
+        // Check that the environment variable is set
+        assert.property(envVars, 'SQL_SPECIAL_CHARS_DB');
+        const credentialsJson = JSON.parse(envVars['SQL_SPECIAL_CHARS_DB']!);
+
+        // Verify that special characters are properly URL-encoded
+        assert.strictEqual(
+            credentialsJson.url,
+            'postgresql://user%40domain:pa%3Ass%40word!%23%24%[email protected]:5432/my%40db%3Aname'
+        );
+        assert.deepStrictEqual(credentialsJson.params, {});
+        assert.strictEqual(credentialsJson.param_style, 'format');
+    });
+
+    test('Normalizes integration ID with spaces and mixed case for env var name', async () => {
+        const uri = Uri.file('/test/notebook.deepnote');
+        const integrationId = 'My Production DB';
+        const config: PostgresIntegrationConfig = {
+            id: integrationId,
+            name: 'Production Database',
+            type: IntegrationType.Postgres,
+            host: 'prod.example.com',
+            port: 5432,
+            database: 'proddb',
+            username: 'admin',
+            password: 'secret',
+            ssl: true
+        };
+
+        const notebook = createMockNotebook(uri, [
+            createMockCell(0, NotebookCellKind.Code, 'sql', 'SELECT * FROM products', {
+                sql_integration_id: integrationId
+            })
+        ]);
+
+        when(mockedVSCodeNamespaces.workspace.notebookDocuments).thenReturn([notebook]);
+        when(integrationStorage.get(integrationId)).thenResolve(config);
+
+        const envVars = await provider.getEnvironmentVariables(uri);
+
+        // Check that the environment variable name is properly normalized
+        // Spaces should be converted to underscores and uppercased
+        assert.property(envVars, 'SQL_MY_PRODUCTION_DB');
+        const credentialsJson = JSON.parse(envVars['SQL_MY_PRODUCTION_DB']!);
+        assert.strictEqual(credentialsJson.url, 'postgresql://admin:[email protected]:5432/proddb');
+        assert.deepStrictEqual(credentialsJson.params, { sslmode: 'require' });
+        assert.strictEqual(credentialsJson.param_style, 'format');
+    });
+
+    test('Normalizes integration ID with special characters for env var name', async () => {
+        const uri = Uri.file('/test/notebook.deepnote');
+        const integrationId = 'my-db@2024!';
+        const config: PostgresIntegrationConfig = {
+            id: integrationId,
+            name: 'Test DB',
+            type: IntegrationType.Postgres,
+            host: 'localhost',
+            port: 5432,
+            database: 'testdb',
+            username: 'user',
+            password: 'pass',
+            ssl: false
+        };
+
+        const notebook = createMockNotebook(uri, [
+            createMockCell(0, NotebookCellKind.Code, 'sql', 'SELECT 1', {
+                sql_integration_id: integrationId
+            })
+        ]);
+
+        when(mockedVSCodeNamespaces.workspace.notebookDocuments).thenReturn([notebook]);
+        when(integrationStorage.get(integrationId)).thenResolve(config);
+
+        const envVars = await provider.getEnvironmentVariables(uri);
+
+        // Check that special characters in integration ID are normalized for env var name
+        // Non-alphanumeric characters should be converted to underscores
+        assert.property(envVars, 'SQL_MY_DB_2024_');
+        const credentialsJson = JSON.parse(envVars['SQL_MY_DB_2024_']!);
+        assert.strictEqual(credentialsJson.url, 'postgresql://user:pass@localhost:5432/testdb');
+    });
 });
 
 function createMockNotebook(uri: Uri, cells: NotebookCell[]): NotebookDocument {