remove redundant placeholders from snowflake form

Author: jankuca

src/messageTypes.ts

@@ -216,18 +216,15 @@ export type LocalizedMessages = {
     integrationsSnowflakeAuthMethodKeyPair: string;
     integrationsSnowflakeUnsupportedAuthMethod: string;
     integrationsSnowflakeUsernameLabel: string;
-    integrationsSnowflakeUsernamePlaceholder: string;
     integrationsSnowflakePasswordLabel: string;
     integrationsSnowflakePasswordPlaceholder: string;
     integrationsSnowflakeServiceAccountUsernameLabel: string;
     integrationsSnowflakeServiceAccountUsernameHelp: string;
-    integrationsSnowflakeServiceAccountUsernamePlaceholder: string;
     integrationsSnowflakePrivateKeyLabel: string;
     integrationsSnowflakePrivateKeyHelp: string;
     integrationsSnowflakePrivateKeyPlaceholder: string;
     integrationsSnowflakePrivateKeyPassphraseLabel: string;
     integrationsSnowflakePrivateKeyPassphraseHelp: string;
-    integrationsSnowflakePrivateKeyPassphrasePlaceholder: string;
     integrationsSnowflakeDatabaseLabel: string;
     integrationsSnowflakeDatabasePlaceholder: string;
     integrationsSnowflakeRoleLabel: string;

src/notebooks/deepnote/integrations/integrationWebview.ts

@@ -166,21 +166,16 @@ export class IntegrationWebviewProvider implements IIntegrationWebviewProvider {
             integrationsSnowflakeAuthMethodKeyPair: localize.Integrations.snowflakeAuthMethodKeyPair,
             integrationsSnowflakeUnsupportedAuthMethod: localize.Integrations.snowflakeUnsupportedAuthMethod,
             integrationsSnowflakeUsernameLabel: localize.Integrations.snowflakeUsernameLabel,
-            integrationsSnowflakeUsernamePlaceholder: localize.Integrations.snowflakeUsernamePlaceholder,
             integrationsSnowflakePasswordLabel: localize.Integrations.snowflakePasswordLabel,
             integrationsSnowflakePasswordPlaceholder: localize.Integrations.snowflakePasswordPlaceholder,
             integrationsSnowflakeServiceAccountUsernameLabel:
                 localize.Integrations.snowflakeServiceAccountUsernameLabel,
             integrationsSnowflakeServiceAccountUsernameHelp: localize.Integrations.snowflakeServiceAccountUsernameHelp,
-            integrationsSnowflakeServiceAccountUsernamePlaceholder:
-                localize.Integrations.snowflakeServiceAccountUsernamePlaceholder,
             integrationsSnowflakePrivateKeyLabel: localize.Integrations.snowflakePrivateKeyLabel,
             integrationsSnowflakePrivateKeyHelp: localize.Integrations.snowflakePrivateKeyHelp,
             integrationsSnowflakePrivateKeyPlaceholder: localize.Integrations.snowflakePrivateKeyPlaceholder,
             integrationsSnowflakePrivateKeyPassphraseLabel: localize.Integrations.snowflakePrivateKeyPassphraseLabel,
             integrationsSnowflakePrivateKeyPassphraseHelp: localize.Integrations.snowflakePrivateKeyPassphraseHelp,
-            integrationsSnowflakePrivateKeyPassphrasePlaceholder:
-                localize.Integrations.snowflakePrivateKeyPassphrasePlaceholder,
             integrationsSnowflakeDatabaseLabel: localize.Integrations.snowflakeDatabaseLabel,
             integrationsSnowflakeDatabasePlaceholder: localize.Integrations.snowflakeDatabasePlaceholder,
             integrationsSnowflakeRoleLabel: localize.Integrations.snowflakeRoleLabel,

src/platform/common/utils/localize.ts

@@ -878,12 +878,11 @@ export namespace Integrations {
     export const snowflakeUsernameLabel = l10n.t('Username');
     export const snowflakeUsernamePlaceholder = l10n.t('user');
     export const snowflakePasswordLabel = l10n.t('Password');
-    export const snowflakePasswordPlaceholder = l10n.t('•••••');
+    export const snowflakePasswordPlaceholder = l10n.t('••••••••');
     export const snowflakeServiceAccountUsernameLabel = l10n.t('Service Account Username');
     export const snowflakeServiceAccountUsernameHelp = l10n.t(
         'The username of the service account that will be used to connect to Snowflake'
     );
-    export const snowflakeServiceAccountUsernamePlaceholder = l10n.t('');
     export const snowflakePrivateKeyLabel = l10n.t('Private Key');
     export const snowflakePrivateKeyHelp = l10n.t(
         'The private key in PEM format. Make sure to include the entire key, including BEGIN and END markers.'
@@ -893,7 +892,7 @@ export namespace Integrations {
     export const snowflakePrivateKeyPassphraseHelp = l10n.t(
         'If the private key is encrypted, provide the passphrase to decrypt it.'
     );
-    export const snowflakePrivateKeyPassphrasePlaceholder = l10n.t('Private key passphrase (optional)');
+    export const snowflakePrivateKeyPassphrasePlaceholder = l10n.t('');
     export const snowflakeDatabaseLabel = l10n.t('Database (optional)');
     export const snowflakeDatabasePlaceholder = l10n.t('');
     export const snowflakeRoleLabel = l10n.t('Role (optional)');

src/webviews/webview-side/integrations/SnowflakeForm.tsx

@@ -172,7 +172,7 @@ export const SnowflakeForm: React.FC<ISnowflakeFormProps> = ({
                     id="name"
                     value={name}
                     onChange={(e) => setName(e.target.value)}
-                    placeholder={getLocString('integrationsSnowflakeNamePlaceholder', '[Demo] Snowflake')}
+                    placeholder={getLocString('integrationsSnowflakeNamePlaceholder', '')}
                     autoComplete="off"
                     disabled={isUnsupported}
                 />
@@ -228,7 +228,6 @@ export const SnowflakeForm: React.FC<ISnowflakeFormProps> = ({
                                 id="username"
                                 value={username}
                                 onChange={(e) => setUsername(e.target.value)}
-                                placeholder={getLocString('integrationsSnowflakeUsernamePlaceholder', '')}
                                 autoComplete="username"
                                 required
                                 pattern=".*\S.*"
@@ -245,7 +244,7 @@ export const SnowflakeForm: React.FC<ISnowflakeFormProps> = ({
                                 id="password"
                                 value={password}
                                 onChange={(e) => setPassword(e.target.value)}
-                                placeholder={getLocString('integrationsSnowflakePasswordPlaceholder', '•••••')}
+                                placeholder={getLocString('integrationsSnowflakePasswordPlaceholder', '••••••••')}
                                 autoComplete="current-password"
                                 required
                                 pattern=".*\S.*"
@@ -273,7 +272,6 @@ export const SnowflakeForm: React.FC<ISnowflakeFormProps> = ({
                                 id="username"
                                 value={username}
                                 onChange={(e) => setUsername(e.target.value)}
-                                placeholder={getLocString('integrationsSnowflakeServiceAccountUsernamePlaceholder', '')}
                                 autoComplete="username"
                                 required
                                 pattern=".*\S.*"
@@ -328,10 +326,6 @@ export const SnowflakeForm: React.FC<ISnowflakeFormProps> = ({
                                 id="privateKeyPassphrase"
                                 value={privateKeyPassphrase}
                                 onChange={(e) => setPrivateKeyPassphrase(e.target.value)}
-                                placeholder={getLocString(
-                                    'integrationsSnowflakePrivateKeyPassphrasePlaceholder',
-                                    'Private key passphrase (optional)'
-                                )}
                                 autoComplete="off"
                                 aria-describedby="privateKeyPassphrase-help"
                             />