fix: Fix tests mocks

Signed-off-by: Tomas Kislan <[email protected]>

Author: tkislan

src/notebooks/deepnote/deepnoteNotebookCommandListener.ts

@@ -213,7 +213,7 @@ export class DeepnoteNotebookCommandListener implements IExtensionSyncActivation
         }
 
         const notebookRange = new NotebookRange(insertIndex, insertIndex + 1);
-        editor.revealRange(notebookRange, NotebookEditorRevealType?.Default ?? 0);
+        editor.revealRange(notebookRange, NotebookEditorRevealType.Default);
         editor.selection = notebookRange;
         // Enter edit mode on the new cell
         await commands.executeCommand('notebook.cell.edit');
@@ -254,7 +254,7 @@ export class DeepnoteNotebookCommandListener implements IExtensionSyncActivation
         }
 
         const notebookRange = new NotebookRange(insertIndex, insertIndex + 1);
-        editor.revealRange(notebookRange, NotebookEditorRevealType?.Default ?? 0);
+        editor.revealRange(notebookRange, NotebookEditorRevealType.Default);
         editor.selection = notebookRange;
         // Enter edit mode on the new cell
         await commands.executeCommand('notebook.cell.edit');
@@ -298,8 +298,7 @@ export class DeepnoteNotebookCommandListener implements IExtensionSyncActivation
         }
 
         const notebookRange = new NotebookRange(insertIndex, insertIndex + 1);
-        // editor.revealRange(notebookRange, NotebookEditorRevealType.Default);
-        editor.revealRange(notebookRange, 0);
+        editor.revealRange(notebookRange, NotebookEditorRevealType.Default);
         editor.selection = notebookRange;
         // Enter edit mode on the new cell
         await commands.executeCommand('notebook.cell.edit');

src/notebooks/deepnote/deepnoteNotebookCommandListener.unit.test.ts

@@ -1,11 +1,5 @@
 import { assert } from 'chai';
 import * as sinon from 'sinon';
-import {
-    DeepnoteNotebookCommandListener,
-    getNextDeepnoteVariableName,
-    InputBlockType
-} from './deepnoteNotebookCommandListener';
-import { IDisposable } from '../../platform/common/types';
 import {
     NotebookCell,
     NotebookDocument,
@@ -18,6 +12,13 @@ import {
     window,
     Uri
 } from 'vscode';
+
+import {
+    DeepnoteNotebookCommandListener,
+    getNextDeepnoteVariableName,
+    InputBlockType
+} from './deepnoteNotebookCommandListener';
+import { IDisposable } from '../../platform/common/types';
 import * as notebookUpdater from '../../kernels/execution/notebookUpdater';
 import { createMockedNotebookDocument } from '../../test/datascience/editor-integration/helpers';
 

src/test/mocks/vsc/extHostedTypes.ts

@@ -2406,6 +2406,29 @@ export namespace vscMockExtHostedTypes {
         }
     }
 
+    /**
+     * Notebook editor reveal type.
+     */
+    export enum NotebookEditorRevealType {
+        /**
+         * The range will be revealed with as little scrolling as possible.
+         */
+        Default = 0,
+        /**
+         * The range will always be revealed in the center of the viewport.
+         */
+        InCenter = 1,
+        /**
+         * If the range is outside the viewport, it will be revealed in the center of the viewport.
+         * Otherwise, it will be revealed with as little scrolling as possible.
+         */
+        InCenterIfOutsideViewport = 2,
+        /**
+         * The range will always be revealed at the top of the viewport.
+         */
+        AtTop = 3
+    }
+
     /**
      * A notebook range represents an ordered pair of two cell indices.
      * It is guaranteed that start is less than or equal to end.

src/test/vscode-mock.ts

@@ -195,3 +195,4 @@ mockedVSCode.QuickPickItemKind = vscodeMocks.vscMockExtHostedTypes.QuickPickItem
 mockedVSCode.NotebookCellOutput = vscodeMocks.vscMockExtHostedTypes.NotebookCellOutput;
 (mockedVSCode as any).NotebookCellOutputItem = vscodeMocks.vscMockExtHostedTypes.NotebookCellOutputItem;
 (mockedVSCode as any).NotebookCellExecutionState = vscodeMocks.vscMockExtHostedTypes.NotebookCellExecutionState;
+(mockedVSCode as any).NotebookEditorRevealType = vscodeMocks.vscMockExtHostedTypes.NotebookEditorRevealType;