Skip to content

Commit b7f2dee

Browse files
committed
refactor mock logger
1 parent 99e86c3 commit b7f2dee

File tree

1 file changed

+16
-40
lines changed

1 file changed

+16
-40
lines changed

src/notebooks/deepnote/deepnoteActivationService.unit.test.ts

Lines changed: 16 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,17 @@ import { IExtensionContext } from '../../platform/common/types';
66
import { ILogger } from '../../platform/logging/types';
77
import { IIntegrationManager } from './integrations/types';
88

9+
function createMockLogger(): ILogger {
10+
return {
11+
error: () => void 0,
12+
warn: () => void 0,
13+
info: () => void 0,
14+
debug: () => void 0,
15+
trace: () => void 0,
16+
ci: () => void 0
17+
} as ILogger;
18+
}
19+
920
suite('DeepnoteActivationService', () => {
1021
let activationService: DeepnoteActivationService;
1122
let mockExtensionContext: IExtensionContext;
@@ -24,14 +35,7 @@ suite('DeepnoteActivationService', () => {
2435
return;
2536
}
2637
};
27-
mockLogger = {
28-
error: () => {},
29-
warn: () => {},
30-
info: () => {},
31-
debug: () => {},
32-
trace: () => {},
33-
ci: () => {}
34-
} as ILogger;
38+
mockLogger = createMockLogger();
3539
activationService = new DeepnoteActivationService(
3640
mockExtensionContext,
3741
manager,
@@ -107,22 +111,8 @@ suite('DeepnoteActivationService', () => {
107111
return;
108112
}
109113
};
110-
const mockLogger1: ILogger = {
111-
error: () => {},
112-
warn: () => {},
113-
info: () => {},
114-
debug: () => {},
115-
trace: () => {},
116-
ci: () => {}
117-
} as ILogger;
118-
const mockLogger2: ILogger = {
119-
error: () => {},
120-
warn: () => {},
121-
info: () => {},
122-
debug: () => {},
123-
trace: () => {},
124-
ci: () => {}
125-
} as ILogger;
114+
const mockLogger1 = createMockLogger();
115+
const mockLogger2 = createMockLogger();
126116
const service1 = new DeepnoteActivationService(context1, manager1, mockIntegrationManager1, mockLogger1);
127117
const service2 = new DeepnoteActivationService(context2, manager2, mockIntegrationManager2, mockLogger2);
128118

@@ -159,22 +149,8 @@ suite('DeepnoteActivationService', () => {
159149
return;
160150
}
161151
};
162-
const mockLogger3: ILogger = {
163-
error: () => {},
164-
warn: () => {},
165-
info: () => {},
166-
debug: () => {},
167-
trace: () => {},
168-
ci: () => {}
169-
} as ILogger;
170-
const mockLogger4: ILogger = {
171-
error: () => {},
172-
warn: () => {},
173-
info: () => {},
174-
debug: () => {},
175-
trace: () => {},
176-
ci: () => {}
177-
} as ILogger;
152+
const mockLogger3 = createMockLogger();
153+
const mockLogger4 = createMockLogger();
178154
new DeepnoteActivationService(context1, manager1, mockIntegrationManager1, mockLogger3);
179155
new DeepnoteActivationService(context2, manager2, mockIntegrationManager2, mockLogger4);
180156

0 commit comments

Comments
 (0)