feat: Localize commands, extract notebook creation logic to reuse in methods

Signed-off-by: Tomas Kislan <[email protected]>

Author: tkislan

package.json

@@ -183,37 +183,37 @@
             },
             {
                 "command": "deepnote.renameProject",
-                "title": "Rename Project",
+                "title": "%deepnote.commands.renameProject.title%",
                 "category": "Deepnote",
                 "icon": "$(edit)"
             },
             {
                 "command": "deepnote.deleteProject",
-                "title": "Delete Project",
+                "title": "%deepnote.commands.deleteProject.title%",
                 "category": "Deepnote",
                 "icon": "$(trash)"
             },
             {
                 "command": "deepnote.renameNotebook",
-                "title": "Rename Notebook",
+                "title": "%deepnote.commands.renameNotebook.title%",
                 "category": "Deepnote",
                 "icon": "$(edit)"
             },
             {
                 "command": "deepnote.deleteNotebook",
-                "title": "Delete Notebook",
+                "title": "%deepnote.commands.deleteNotebook.title%",
                 "category": "Deepnote",
                 "icon": "$(trash)"
             },
             {
                 "command": "deepnote.duplicateNotebook",
-                "title": "Duplicate Notebook",
+                "title": "%deepnote.commands.duplicateNotebook.title%",
                 "category": "Deepnote",
                 "icon": "$(copy)"
             },
             {
                 "command": "deepnote.addNotebookToProject",
-                "title": "Add Notebook",
+                "title": "%deepnote.commands.addNotebookToProject.title%",
                 "category": "Deepnote",
                 "icon": "$(add)"
             },

package.nls.json

@@ -265,6 +265,12 @@
     "deepnote.commands.addInputFileBlock.title": "Add Input File Block",
     "deepnote.commands.addButtonBlock.title": "Add Button Block",
     "deepnote.commands.newNotebook.title": "New Notebook",
+    "deepnote.commands.renameProject.title": "Rename Project",
+    "deepnote.commands.deleteProject.title": "Delete Project",
+    "deepnote.commands.renameNotebook.title": "Rename Notebook",
+    "deepnote.commands.deleteNotebook.title": "Delete Notebook",
+    "deepnote.commands.duplicateNotebook.title": "Duplicate Notebook",
+    "deepnote.commands.addNotebookToProject.title": "Add Notebook",
     "deepnote.views.explorer.name": "Explorer",
     "deepnote.views.explorer.welcome": "No Deepnote notebooks found in this workspace.",
     "deepnote.command.selectNotebook.title": "Select Notebook"

src/notebooks/deepnote/deepnoteExplorerView.ts

@@ -227,6 +227,47 @@ export class DeepnoteExplorerView {
         });
     }
 
+    /**
+     * Shared helper that creates and adds a new notebook to a project
+     * @param fileUri The URI of the project file
+     * @param projectId The project ID
+     * @returns Object with notebook ID and name if successful, or null if aborted/failed
+     */
+    private async createAndAddNotebookToProject(
+        fileUri: Uri,
+        projectId: string
+    ): Promise<{ id: string; name: string } | null> {
+        // Read the Deepnote project file
+        const projectData = await this.readDeepnoteProjectFile(fileUri);
+
+        if (!projectData?.project) {
+            await window.showErrorMessage(l10n.t('Invalid Deepnote file format'));
+            return null;
+        }
+
+        // Generate suggested name and prompt user
+        const suggestedName = this.generateSuggestedNotebookName(projectData);
+        const notebookName = await this.promptForNotebookName(suggestedName);
+
+        if (!notebookName) {
+            return null;
+        }
+
+        // Create new notebook with initial block
+        const newNotebook = this.createNotebookWithFirstBlock(notebookName);
+
+        // Add new notebook to the project (initialize array if needed)
+        if (!projectData.project.notebooks) {
+            projectData.project.notebooks = [];
+        }
+        projectData.project.notebooks.push(newNotebook);
+
+        // Save and open the new notebook
+        await this.saveProjectAndOpenNotebook(fileUri, projectData, projectId, newNotebook.id);
+
+        return { id: newNotebook.id, name: notebookName };
+    }
+
     private refreshExplorer(): void {
         this.treeDataProvider.refresh();
     }
@@ -450,35 +491,12 @@ export class DeepnoteExplorerView {
         }
 
         try {
-            // Read the current file
-            const projectData = await this.readDeepnoteProjectFile(fileUri);
-
-            if (!projectData?.project) {
-                await window.showErrorMessage(l10n.t('Invalid Deepnote file format'));
-                return;
-            }
-
-            // Generate suggested name and prompt user
-            const suggestedName = this.generateSuggestedNotebookName(projectData);
-            const notebookName = await this.promptForNotebookName(suggestedName);
-
-            if (!notebookName) {
-                return;
-            }
-
-            // Create new notebook with initial block
-            const newNotebook = this.createNotebookWithFirstBlock(notebookName);
+            // Use shared helper to create and add notebook
+            const result = await this.createAndAddNotebookToProject(fileUri, projectId);
 
-            // Add new notebook to the project
-            if (!projectData.project.notebooks) {
-                projectData.project.notebooks = [];
+            if (result) {
+                await window.showInformationMessage(l10n.t('Created new notebook: {0}', result.name));
             }
-            projectData.project.notebooks.push(newNotebook);
-
-            // Save and open the new notebook
-            await this.saveProjectAndOpenNotebook(fileUri, projectData, projectId, newNotebook.id);
-
-            await window.showInformationMessage(l10n.t('Created new notebook: {0}', notebookName));
         } catch (error) {
             const errorMessage = error instanceof Error ? error.message : 'Unknown error';
             await window.showErrorMessage(l10n.t('Failed to add notebook: {0}', errorMessage));
@@ -946,34 +964,13 @@ export class DeepnoteExplorerView {
 
         try {
             const fileUri = Uri.file(treeItem.context.filePath);
-            const projectData = await this.readDeepnoteProjectFile(fileUri);
-
-            if (!projectData?.project) {
-                await window.showErrorMessage(l10n.t('Invalid Deepnote file format'));
-                return;
-            }
 
-            // Generate suggested name and prompt user
-            const suggestedName = this.generateSuggestedNotebookName(projectData);
-            const notebookName = await this.promptForNotebookName(suggestedName);
+            // Use shared helper to create and add notebook
+            const result = await this.createAndAddNotebookToProject(fileUri, projectId);
 
-            if (!notebookName) {
-                return;
+            if (result) {
+                await window.showInformationMessage(l10n.t('Created new notebook: {0}', result.name));
             }
-
-            // Create new notebook with initial block
-            const newNotebook = this.createNotebookWithFirstBlock(notebookName);
-
-            // Add new notebook to the project
-            if (!projectData.project.notebooks) {
-                projectData.project.notebooks = [];
-            }
-            projectData.project.notebooks.push(newNotebook);
-
-            // Save and open the new notebook
-            await this.saveProjectAndOpenNotebook(fileUri, projectData, projectId, newNotebook.id);
-
-            await window.showInformationMessage(l10n.t('Created new notebook: {0}', notebookName));
         } catch (error) {
             const errorMessage = error instanceof Error ? error.message : 'Unknown error';
             await window.showErrorMessage(l10n.t('Failed to add notebook: {0}', errorMessage));