Skip to content

Commit c4b12c5

Browse files
committed
fix the build
1 parent 9d96c54 commit c4b12c5

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

build/esbuild/build.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ const commonExternals = [
4848
'vscode',
4949
'commonjs',
5050
'node:crypto',
51+
'node:fs/promises',
52+
'node:path',
5153
'vscode-jsonrpc', // Used by a few modules, might as well pull this out, instead of duplicating it in separate bundles.
5254
// Ignore telemetry specific packages that are not required.
5355
'applicationinsights-native-metrics',

src/notebooks/deepnote/deepnoteDataConverter.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,14 @@ export class DeepnoteDataConverter {
8989
// Outputs are managed by VS Code natively, not stored in the pocket
9090
// Preserve outputs when they exist (including newly produced outputs)
9191
// Only set if not already set to avoid overwriting converter-managed outputs
92-
// Only set if the cell actually has outputs (non-empty array) or if the block originally had outputs
9392
const hadOutputs = cell.metadata?.__hadOutputs;
94-
if (cell.outputs && !block.outputs && (cell.outputs.length > 0 || hadOutputs)) {
95-
block.outputs = this.transformOutputsForDeepnote(cell.outputs);
93+
if (!block.outputs) {
94+
// Set outputs if:
95+
// 1. The cell has non-empty outputs, OR
96+
// 2. The block originally had outputs (even if empty)
97+
if ((cell.outputs && cell.outputs.length > 0) || hadOutputs) {
98+
block.outputs = cell.outputs ? this.transformOutputsForDeepnote(cell.outputs) : [];
99+
}
96100
}
97101

98102
// Clean up internal tracking flags from metadata

0 commit comments

Comments
 (0)