Skip to content

Commit d9afa1a

Browse files
committed
fix: Merge cleanup
1 parent 3bdf030 commit d9afa1a

File tree

7 files changed

+4
-248
lines changed

7 files changed

+4
-248
lines changed

src/kernels/deepnote/deepnoteController.ts

Lines changed: 0 additions & 84 deletions
This file was deleted.

src/notebooks/deepnote/deepnoteDataConverter.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { addPocketToCellMetadata, createBlockFromPocket } from './pocket';
88
import { TextBlockConverter } from './converters/textBlockConverter';
99
import { MarkdownBlockConverter } from './converters/markdownBlockConverter';
1010
import { ChartBigNumberBlockConverter } from './converters/chartBigNumberBlockConverter';
11-
import { CHART_BIG_NUMBER_MIME_TYPE, OUTPUT_BLOCK_METADATA_KEY } from './deepnoteConstants';
11+
import { CHART_BIG_NUMBER_MIME_TYPE } from '../../platform/deepnote/deepnoteConstants';
1212

1313
/**
1414
* Utility class for converting between Deepnote block structures and VS Code notebook cells.
@@ -219,14 +219,6 @@ export class DeepnoteDataConverter {
219219

220220
if (Object.keys(restMetadata).length > 0) {
221221
(deepnoteOutput as DeepnoteOutput & { metadata?: Record<string, unknown> }).metadata = restMetadata;
222-
223-
if (
224-
deepnoteOutput.metadata != null &&
225-
typeof deepnoteOutput.metadata === 'object' &&
226-
OUTPUT_BLOCK_METADATA_KEY in deepnoteOutput.metadata
227-
) {
228-
delete deepnoteOutput.metadata[OUTPUT_BLOCK_METADATA_KEY];
229-
}
230222
}
231223
}
232224

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
1-
export const OUTPUT_BLOCK_METADATA_KEY = 'blockMetadata';
2-
31
export const CHART_BIG_NUMBER_MIME_TYPE = 'application/vnd.deepnote.chart.big-number+json';

src/webviews/extension-side/dataframe/rendererComms.ts

Lines changed: 0 additions & 124 deletions
This file was deleted.

src/webviews/webview-side/chart-big-number-renderer/index.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ import type { ActivationFunction, OutputItem, RendererContext } from 'vscode-not
88
import { ChartBigNumberOutputRenderer } from './ChartBigNumberOutputRenderer';
99
import {
1010
DeepnoteBigNumberMetadataSchema,
11-
DeepnoteChartBigNumberOutputSchema,
12-
getDeepnoteBlockMetadataSchema
11+
DeepnoteChartBigNumberOutputSchema
1312
} from '../../../notebooks/deepnote/deepnoteSchemas';
1413

1514
export const activate: ActivationFunction = (_context: RendererContext<unknown>) => {
@@ -18,9 +17,7 @@ export const activate: ActivationFunction = (_context: RendererContext<unknown>)
1817
try {
1918
// Remove single quotes from start and end of string if present
2019
const data = JSON.parse(outputItem.text().replace(/^'|'$/g, ''));
21-
const { blockMetadata } = getDeepnoteBlockMetadataSchema(DeepnoteBigNumberMetadataSchema).parse(
22-
outputItem.metadata
23-
);
20+
const blockMetadata = DeepnoteBigNumberMetadataSchema.parse(outputItem.metadata);
2421

2522
const chartBigNumberOutput = DeepnoteChartBigNumberOutputSchema.parse(data);
2623

src/webviews/webview-side/dataframe-renderer/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ export const activate: ActivationFunction = (context: RendererContext<unknown>)
3535
console.log(`[DataframeRenderer] Extracted cellId: ${cellId}, cellIndex: ${cellIndex}`);
3636

3737
const root = document.createElement('div');
38+
3839
element.appendChild(root);
3940

4041
ReactDOM.render(

src/webviews/webview-side/dataframe-renderer/styles.css

Lines changed: 0 additions & 24 deletions
This file was deleted.

0 commit comments

Comments
 (0)